chrome/browser/resources/settings/internet_page/internet_page.html - Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_page.html

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/device_page.html ('k') | chrome/browser/resources/settings/languages_page/languages_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_page.html

diff --git a/chrome/browser/resources/settings/internet_page/internet_page.html b/chrome/browser/resources/settings/internet_page/internet_page.html

index b83b36cccffd489d757cb7b15cd4b8b9921fb867..8249812b3533836bce3e371d09602662bc597cb3 100644

--- a/chrome/browser/resources/settings/internet_page/internet_page.html

+++ b/chrome/browser/resources/settings/internet_page/internet_page.html

@@ -24,7 +24,7 @@

}

</style>

<settings-animated-pages id="pages" section="internet">

- <neon-animatable id="main">

+ <neon-animatable route-path="default">

<network-summary on-show-detail="onShowDetail_"

default-network="{{defaultNetwork}}"

on-show-known-networks="onShowKnownNetworks_"

@@ -51,7 +51,7 @@

</div>

</template>

</neon-animatable>

- <template is="dom-if" name="network-detail" no-search>

+ <template is="dom-if" route-path="/networkDetail" no-search>

<settings-subpage page-title="$i18n{internetDetailPageTitle}">

<settings-internet-detail-page

guid="[[detailGuid]]"

@@ -60,7 +60,7 @@

</settings-internet-detail-page>

</settings-subpage>

</template>

- <template is="dom-if" name="known-networks" no-search>

+ <template is="dom-if" route-path="/knownNetworks" no-search>

<settings-subpage page-title="$i18n{internetKnownNetworksPageTitle}">

<settings-internet-known-networks-page

network-type="[[knownNetworksType]]"