Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2878)

Unified Diff: chrome/browser/resources/settings/device_page/device_page.html

Issue 2224163002: Settings Router Refactor: Replace route.subpage usage with route.path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/device_page.html
diff --git a/chrome/browser/resources/settings/device_page/device_page.html b/chrome/browser/resources/settings/device_page/device_page.html
index f910dfc5744dd8e019082457b724d88929f55df1..0ae40c7d8a732ba33819e4287c566659858f50b0 100644
--- a/chrome/browser/resources/settings/device_page/device_page.html
+++ b/chrome/browser/resources/settings/device_page/device_page.html
@@ -20,7 +20,7 @@
<template>
<style include="settings-shared"></style>
<settings-animated-pages id="pages" section="device">
- <neon-animatable id="main">
+ <neon-animatable id="main" route-path="default">
<div id="pointersRow" class="settings-box first"
on-tap="onPointersTap_" actionable>
<iron-icon icon="[[getPointersIcon_(hasMouse_, hasTouchpad_)]]">
@@ -47,7 +47,7 @@
<div class="middle">$i18n{displayTitle}</div>
</div>
</neon-animatable>
- <template is="dom-if" name="pointers">
+ <template is="dom-if" route-path="/pointer-overlay">
<settings-subpage
associated-control="[[$$('#pointersRow')]]"
page-title="[[getPointersTitle_(hasMouse_, hasTouchpad_)]]">
@@ -56,7 +56,7 @@
</settings-pointers>
</settings-subpage>
</template>
- <template is="dom-if" name="keyboard">
+ <template is="dom-if" route-path="/keyboard-overlay">
<settings-subpage
associated-control="[[$$('#keyboardRow')]]"
page-title="$i18n{keyboardTitle}">
@@ -64,7 +64,7 @@
</settings-subpage>
</template>
<template is="dom-if" if=[[noteAllowed_]]>
- <template is="dom-if" name="note">
+ <template is="dom-if" route-path="/note">
<settings-subpage
associated-control="[[$$('#noteRow')]]"
page-title="$i18n{noteTitle}">
@@ -72,7 +72,7 @@
</settings-subpage>
</template>
</template>
- <template is="dom-if" name="display">
+ <template is="dom-if" route-path="/display">
<settings-subpage
associated-control="[[$$('#displayRow')]]"
page-title="$i18n{displayTitle}">

Powered by Google App Engine
This is Rietveld 408576698