Convert some spell-checking layout tests to use unified text checker

Convert some spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
Committed: https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf
Cr-Commit-Position: refs/heads/master@{#411025}

[Xiaocheng, 2016-08-09 06:36:55]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 06:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-09 06:42:15]

Description was changed from

==========
Enable unified textchecker by default in all tests

BUG=633509
==========

to

==========
Enable unified text checker by default in all tests

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and use it
to convert several layout tests that assume unified text checker disabled.

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[Xiaocheng, 2016-08-09 06:46:16]

Description was changed from

==========
Enable unified text checker by default in all tests

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and use it
to convert several layout tests that assume unified text checker disabled.

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and use it
to convert several layout tests that assume unified text checker disabled.

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[Xiaocheng, 2016-08-09 07:14:32]

Description was changed from

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and use it
to convert several layout tests that assume unified text checker disabled.

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker.

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[commit-bot: I haz the power, 2016-08-09 07:39:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 07:39:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xiaocheng, 2016-08-09 12:07:07]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 12:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 12:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 12:22:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-08-09 13:20:14]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 13:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 14:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 14:44:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2016-08-09 15:13:17]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 15:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 16:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:47:26]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-10 05:58:29]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 05:58:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-10 06:04:07]

Description was changed from

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker.

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[Xiaocheng, 2016-08-10 06:07:50]

Description was changed from

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

The following layout tests need rebaseline because their pixel result
will contain misspelling markers with unified text checker enabled,
though they are not testing spell checker or markers:
- fast/dom/blur-contenteditable.html
- fast/inline-block/14498-positionForCoordinates.html
- fast/repaint/inline-outline-repaint.html
- fast/dom/focus-contenteditable.html
-
virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html
- fast/forms/text/input-double-click-selection-gap-bug.html
-
compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html

BUG=633509
==========

[Xiaocheng, 2016-08-10 06:08:44]

xiaochengh@chromium.org changed reviewers:
+ nick@chromium.org, tkent@chromium.org

[Xiaocheng, 2016-08-10 06:08:45]

PTAL.

[Xiaocheng, 2016-08-10 06:09:58]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-10 06:09:59]

+yosin@ for the changed layout tests

[commit-bot: I haz the power, 2016-08-10 07:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:25:18]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-10 07:49:45]

lgtm

Grate rewriting to use w3c test harness!

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html
(right):

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html:4:
<script src=../../resources/testharness.js></script>
So nice! (^_^)b

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html:22:
testRunner.execCommand("DeleteBackward");
nit: Could you use single-quote since other parts of this script use
single-quote?

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-disabled.html
(right):

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-disabled.html:23:
document.execCommand("InsertText", false, 'z');
nit: Could you use single-quote since other parts of this script use
single-quote.

[Xiaocheng, 2016-08-10 08:06:33]

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html
(right):

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/delete-misspelled-word.html:22:
testRunner.execCommand("DeleteBackward");
On 2016/08/10 at 07:49:44, Yosi_UTC9 wrote:
> nit: Could you use single-quote since other parts of this script use
single-quote?

Whoops. Didn't notice that during copy-and-paste.

Done.

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-disabled.html
(right):

https://codereview.chromium.org/2224103003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spellcheck-paste-disabled.html:23:
document.execCommand("InsertText", false, 'z');
On 2016/08/10 at 07:49:44, Yosi_UTC9 wrote:
> nit: Could you use single-quote since other parts of this script use
single-quote.

Done.

[Xiaocheng, 2016-08-10 08:06:46]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 08:07:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-10 09:31:41]

xiaochengh@chromium.org changed reviewers:
- nick@chromium.org, tkent@chromium.org

[Xiaocheng, 2016-08-10 09:31:42]

-nick,tkent from reviewers

I'm changing my split. In this CL I'll convert all spell-checking layout tests
to use w3c test harness and unified text checker. In a follow up CL I'll fix
unified text checker as on.

[Xiaocheng, 2016-08-10 09:33:12]

Description was changed from

==========
Enable unified text checker by default in all tests

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in tests so that we can get rid of this
option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

The following layout tests need rebaseline because their pixel result
will contain misspelling markers with unified text checker enabled,
though they are not testing spell checker or markers:
- fast/dom/blur-contenteditable.html
- fast/inline-block/14498-positionForCoordinates.html
- fast/repaint/inline-outline-repaint.html
- fast/dom/focus-contenteditable.html
-
virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html
- fast/forms/text/input-double-click-selection-gap-bug.html
-
compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html

BUG=633509
==========

to

==========
Convert spell-checking layout tests to use w3c testharness and unified text
checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[Xiaocheng, 2016-08-10 09:34:25]

Description was changed from

==========
Convert spell-checking layout tests to use w3c testharness and unified text
checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert several layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Convert spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[Xiaocheng, 2016-08-10 09:41:38]

Description was changed from

==========
Convert spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Convert some spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

[Xiaocheng, 2016-08-10 09:43:28]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-08-10 09:43:29]

I'm committing this patch directly since everything in this patch has been
l-g-t-m-ed.

Other layout tests will be converted in follow-up patches.

[Xiaocheng, 2016-08-10 09:43:29]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2224103003/#ps140001
(title: "add setUnifiedTextCheckerEnabled(true) in util.js")

[commit-bot: I haz the power, 2016-08-10 09:43:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 11:55:43]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-10 11:57:23]

Description was changed from

==========
Convert some spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509
==========

to

==========
Convert some spell-checking layout tests to unified text checker

Currently the only place unified text checker can be disabled is test.
This patch makes it enabled in all relevant layout tests so that we
can get rid of this option later.

This patch also introduces runSpellingTest() in util.js for running
asynchronous w3c-testharness tests for spell checking, and uses it
to convert those layout tests that disabled unified text checker:
- editing/spelling/delete-misspelled-word.html
- editing/spelling/focusing-other-frame.html
- editing/spelling/spellcheck-paste-continuous-disabled.html
- editing/spelling/spellcheck-paste-disabled.html

editing/spelling/spelling-insert-html.html is removed because the
behavior tested no longer exists with unified text checker.

BUG=633509

Committed: https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf
Cr-Commit-Position: refs/heads/master@{#411025}
==========

[commit-bot: I haz the power, 2016-08-10 11:57:24]

Patchset 8 (id:??) landed as
https://crrev.com/3ada60188def7bc2db291738441ede9262426eaf
Cr-Commit-Position: refs/heads/master@{#411025}