Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2230783003: Convert editing/spelling/grammar-paste.html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@EnableUnifiedTextCheckerByDefault
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/spelling/grammar-paste.html to use w3c test harness This patch is a preparation for fixing unified text checker as always enabled in all tests. BUG=633509 TEST=n/a; this patch changes a test file Committed: https://crrev.com/d2c22631430d19ef40f61c1d2941e3615cfb90b6 Cr-Commit-Position: refs/heads/master@{#411538}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revise use of quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -106 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html View 1 2 chunks +53 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-10 10:22:08 UTC) #4
yosin_UTC9
lgtm w/ small nit about single/double-quote https://codereview.chromium.org/2230783003/diff/1/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html File third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html (right): https://codereview.chromium.org/2230783003/diff/1/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html#newcode71 third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html:71: document.execCommand("Copy"); Let's use ...
4 years, 4 months ago (2016-08-12 01:45:42 UTC) #7
Xiaocheng
Thanks. Committing with quotes changed. https://codereview.chromium.org/2230783003/diff/1/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html File third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html (right): https://codereview.chromium.org/2230783003/diff/1/third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html#newcode71 third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html:71: document.execCommand("Copy"); On 2016/08/12 at ...
4 years, 4 months ago (2016-08-12 02:11:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230783003/20001
4 years, 4 months ago (2016-08-12 02:12:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230783003/20001
4 years, 4 months ago (2016-08-12 02:19:34 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 03:21:56 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 03:24:17 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2c22631430d19ef40f61c1d2941e3615cfb90b6
Cr-Commit-Position: refs/heads/master@{#411538}

Powered by Google App Engine
This is Rietveld 408576698