Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1891)

Unified Diff: chrome/browser/resources/md_history/PRESUBMIT.py

Issue 2224003003: Vulcanize MD History to improve page-load performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/PRESUBMIT.py
diff --git a/chrome/browser/resources/md_history/PRESUBMIT.py b/chrome/browser/resources/md_history/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..0f0b511dd73ff73a9b9b7f9e49837c6636df1161
--- /dev/null
+++ b/chrome/browser/resources/md_history/PRESUBMIT.py
@@ -0,0 +1,26 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+
+def CheckChangeOnUpload(input_api, output_api):
+ """Warn when changing md_history without vulcanizing."""
+
+ def _is_md_history_file(path):
+ return (path.startswith('chrome/browser/resources/md_history') and
+ (not path.endswith('externs.js')) and
+ (path.endswith('js') or path.endswith('html')))
+
+ def _affects_file(filename, paths):
+ return any([filename in path for path in paths])
+
+ paths = [x.LocalPath() for x in input_api.change.AffectedFiles()]
+ vulcanize_changes = (_affects_file('md_history/app.vulcanized.html', paths) or
+ _affects_file('md_history/app.crisper.js', paths))
+ history_changes = filter(_is_md_history_file, paths)
+
+ if history_changes and not vulcanize_changes:
+ return [output_api.PresubmitPromptWarning(
+ 'Vulcanize must be run when changing files in md_history. See '
+ 'docs/vulcanize.md.')]
+ return []
« no previous file with comments | « chrome/browser/resources/md_downloads/vulcanize_readme.md ('k') | chrome/browser/resources/md_history/app.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698