Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/resources/md_history/PRESUBMIT.py

Issue 2224003003: Vulcanize MD History to improve page-load performance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5
6 def CheckChangeOnUpload(input_api, output_api):
7 """Warn when changing md_history without vulcanizing."""
8
9 def _is_md_history_file(path):
10 return (path.startswith('chrome/browser/resources/md_history') and
11 (not path.endswith('externs.js')) and
12 (path.endswith('js') or path.endswith('html')))
13
14 def _affects_file(filename, paths):
15 return any([filename in path for path in paths])
16
17 paths = [x.LocalPath() for x in input_api.change.AffectedFiles()]
18 vulcanize_changes = (_affects_file('md_history/app.vulcanized.html', paths) or
19 _affects_file('md_history/app.crisper.js', paths))
20 history_changes = filter(_is_md_history_file, paths)
21
22 if history_changes and not vulcanize_changes:
23 return [output_api.PresubmitPromptWarning(
24 'Vulcanize must be run when changing files in md_history. See '
25 'docs/vulcanize.md.')]
26 return []
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_downloads/vulcanize_readme.md ('k') | chrome/browser/resources/md_history/app.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698