[ast][parsing] Variable declaration cleanups.

[ast][parsing] Variable declaration cleanups.

- Remove Declaration::initialization(), move logic into parser.
  The backends should only care about the actual initialization flag on the
  variable.
- Introduce DeclareVariable convenience function that covers most cases of
  variable declarations.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/54ff89b2e6bd6fc4421fd52c63c5e427103f7611
Cr-Commit-Position: refs/heads/master@{#38477}

[neis, 2016-08-08 12:02:03]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 12:02:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-08-08 12:41:23]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 12:41:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-08-08 12:54:01]

PTAL. I'm happy to wait with this until you landed your CL that removes the
resolve argument from Declare.

[commit-bot: I haz the power, 2016-08-08 13:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 13:10:37]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-08 17:32:28]

lgtm once you've dealt with the DefaultInitializationFlag helper (feel free to
leave it in Parser if there's some reason I'm not thinking of to do so).

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1974: InitializationFlag
Parser::DefaultInitializationFlag(VariableMode mode) {
What about just putting this with the InitializationFlag enum definition in
globals.h? Its placement as an instance method of Parser makes it look like it
might depend on something _about_ parser, but it doesn't.

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1975: return mode == VAR ? kCreatedInitialized :
kNeedsInitialization;
Maybe add a DCHECK(IsDeclaredVariableMode(mode)) above this?

[neis, 2016-08-09 08:17:52]

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1974: InitializationFlag
Parser::DefaultInitializationFlag(VariableMode mode) {
On 2016/08/08 17:32:28, adamk wrote:
> What about just putting this with the InitializationFlag enum definition in
> globals.h? Its placement as an instance method of Parser makes it look like it
> might depend on something _about_ parser, but it doesn't.

Oops, this was of course supposed to be a static method.  I'm leaving it in the
parser for now, but I want to discuss this again.

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1975: return mode == VAR ? kCreatedInitialized :
kNeedsInitialization;
On 2016/08/08 17:32:28, adamk wrote:
> Maybe add a DCHECK(IsDeclaredVariableMode(mode)) above this?

Done.

[neis, 2016-08-09 08:18:01]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-09 08:18:01]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2223843002/#ps60001
(title: "Rebase and make DefaultInitializationFlag static.")

[commit-bot: I haz the power, 2016-08-09 08:18:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 08:48:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-09 08:49:06]

Description was changed from

==========
[ast][parsing] Variable declaration cleanups.

- Remove Declaration::initialization(), move logic into parser.
  The backends should only care about the actual initialization flag on the
  variable.
- Introduce DeclareVariable convenience function that covers most cases of
  variable declarations.

R=adamk@chromium.org
BUG=
==========

to

==========
[ast][parsing] Variable declaration cleanups.

- Remove Declaration::initialization(), move logic into parser.
  The backends should only care about the actual initialization flag on the
  variable.
- Introduce DeclareVariable convenience function that covers most cases of
  variable declarations.

R=adamk@chromium.org
BUG=

Committed: https://crrev.com/54ff89b2e6bd6fc4421fd52c63c5e427103f7611
Cr-Commit-Position: refs/heads/master@{#38477}
==========

[commit-bot: I haz the power, 2016-08-09 08:49:07]

Patchset 4 (id:??) landed as
https://crrev.com/54ff89b2e6bd6fc4421fd52c63c5e427103f7611
Cr-Commit-Position: refs/heads/master@{#38477}

[adamk, 2016-08-09 16:27:09]

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2223843002/diff/40001/src/parsing/parser.cc#n...
src/parsing/parser.cc:1974: InitializationFlag
Parser::DefaultInitializationFlag(VariableMode mode) {
On 2016/08/09 08:17:52, neis wrote:
> On 2016/08/08 17:32:28, adamk wrote:
> > What about just putting this with the InitializationFlag enum definition in
> > globals.h? Its placement as an instance method of Parser makes it look like
it
> > might depend on something _about_ parser, but it doesn't.
> 
> Oops, this was of course supposed to be a static method.  I'm leaving it in
the
> parser for now, but I want to discuss this again.

Ah, forgot PatternRewriter is an inner class, this looks fine now.