Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Side by Side Diff: src/ast/ast.cc

Issue 2223843002: [ast][parsing] Variable declaration cleanups. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase and make DefaultInitializationFlag static. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/parsing/parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/ast.h" 5 #include "src/ast/ast.h"
6 6
7 #include <cmath> // For isfinite. 7 #include <cmath> // For isfinite.
8 8
9 #include "src/ast/prettyprinter.h" 9 #include "src/ast/prettyprinter.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 MaterializedLiteral* AstNode::AsMaterializedLiteral() { 58 MaterializedLiteral* AstNode::AsMaterializedLiteral() {
59 switch (node_type()) { 59 switch (node_type()) {
60 LITERAL_NODE_LIST(RETURN_NODE); 60 LITERAL_NODE_LIST(RETURN_NODE);
61 default: 61 default:
62 return nullptr; 62 return nullptr;
63 } 63 }
64 } 64 }
65 65
66 #undef RETURN_NODE 66 #undef RETURN_NODE
67 67
68 InitializationFlag Declaration::initialization() const {
69 switch (node_type()) {
70 #define GENERATE_CASE(Node) \
71 case k##Node: \
72 return static_cast<const Node*>(this)->initialization();
73 DECLARATION_NODE_LIST(GENERATE_CASE);
74 #undef GENERATE_CASE
75 default:
76 UNREACHABLE();
77 return kNeedsInitialization;
78 }
79 }
80
81 bool Expression::IsSmiLiteral() const { 68 bool Expression::IsSmiLiteral() const {
82 return IsLiteral() && AsLiteral()->value()->IsSmi(); 69 return IsLiteral() && AsLiteral()->value()->IsSmi();
83 } 70 }
84 71
85 72
86 bool Expression::IsStringLiteral() const { 73 bool Expression::IsStringLiteral() const {
87 return IsLiteral() && AsLiteral()->value()->IsString(); 74 return IsLiteral() && AsLiteral()->value()->IsString();
88 } 75 }
89 76
90 bool Expression::IsPropertyName() const { 77 bool Expression::IsPropertyName() const {
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
978 bool Literal::Match(void* literal1, void* literal2) { 965 bool Literal::Match(void* literal1, void* literal2) {
979 const AstValue* x = static_cast<Literal*>(literal1)->raw_value(); 966 const AstValue* x = static_cast<Literal*>(literal1)->raw_value();
980 const AstValue* y = static_cast<Literal*>(literal2)->raw_value(); 967 const AstValue* y = static_cast<Literal*>(literal2)->raw_value();
981 return (x->IsString() && y->IsString() && x->AsString() == y->AsString()) || 968 return (x->IsString() && y->IsString() && x->AsString() == y->AsString()) ||
982 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber()); 969 (x->IsNumber() && y->IsNumber() && x->AsNumber() == y->AsNumber());
983 } 970 }
984 971
985 972
986 } // namespace internal 973 } // namespace internal
987 } // namespace v8 974 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast/ast.h ('k') | src/parsing/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698