Expose effective connection type to Cronet

net/nqe/effective_connection_type.h

Index: net/nqe/effective_connection_type.h
diff --git a/net/nqe/effective_connection_type.h b/net/nqe/effective_connection_type.h
index 6160a4d69bd6756a39c13070ec2ae181f8c33efe..feb42df2c98834500bda796ecb1ba92834b9ef72 100644
--- a/net/nqe/effective_connection_type.h
+++ b/net/nqe/effective_connection_type.h
@@ -15,6 +15,12 @@ namespace net {
 // EffectiveConnectionType of a network is independent of if the current
 // connection is metered or not. For example, an unmetered slow connection may
 // have EFFECTIVE_CONNECTION_TYPE_SLOW_2G as its effective connection type.
+// An invalid Java prefix to strip is specified to prevent the Java class
+// generator from automatically stripping off the common prefix
+// ("EFFECTIVE_CONNECTION_TYPE_").
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
+// GENERATED_JAVA_CLASS_NAME_OVERRIDE: EffectiveConnectionType

[xunjieli, 2016/08/09 13:22:44]

You can omit this line 22.

[tbansal1, 2016/08/09 17:59:16]

Done.

+// GENERATED_JAVA_PREFIX_TO_STRIP: PREFIX_NOT_PRESENT_

[xunjieli, 2016/08/09 13:22:44]

Do you need to keep the prefix? If not, can we strip the
EFFECTIVE_CONNECTION_TYPE_?

[tbansal1, 2016/08/09 17:59:16]

If I remove this, then EFFECTIVE_CONNECTION_TYPE_ is automatically stripped, and
the variable names in the java file reduce to
UNKNOWN
OFFLINE
SLOW_2G
2G // This fails to compile, and it is also against conventions.
...

[xunjieli, 2016/08/10 17:39:43]

Acknowledged.

 enum EffectiveConnectionType {
   // The connection types should be in increasing order of quality.
   EFFECTIVE_CONNECTION_TYPE_UNKNOWN = 0,