Expose effective connection type to Cronet

net/nqe/effective_connection_type.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_NQE_EFFECTIVE_CONNECTION_TYPE_H_
 #define NET_NQE_EFFECTIVE_CONNECTION_TYPE_H_
 
 namespace net {
 
 // EffectiveConnectionType is the connection type whose typical performance is
 // most similar to the measured performance of the network in use. In many
 // cases, the "effective" connection type and the actual type of connection in
 // use are the same, but often a network connection performs significantly
 // differently, usually worse, from its expected capabilities.
 // EffectiveConnectionType of a network is independent of if the current
 // connection is metered or not. For example, an unmetered slow connection may
 // have EFFECTIVE_CONNECTION_TYPE_SLOW_2G as its effective connection type.
+// An invalid Java prefix to strip is specified to prevent the Java class
+// generator from automatically stripping off the common prefix
+// ("EFFECTIVE_CONNECTION_TYPE_").
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.net
+// GENERATED_JAVA_CLASS_NAME_OVERRIDE: EffectiveConnectionType

[xunjieli, 2016/08/09 13:22:44]

You can omit this line 22.

[tbansal1, 2016/08/09 17:59:16]

Done.

+// GENERATED_JAVA_PREFIX_TO_STRIP: PREFIX_NOT_PRESENT_

[xunjieli, 2016/08/09 13:22:44]

Do you need to keep the prefix? If not, can we strip the
EFFECTIVE_CONNECTION_TYPE_?

[tbansal1, 2016/08/09 17:59:16]

If I remove this, then EFFECTIVE_CONNECTION_TYPE_ is automatically stripped, and
the variable names in the java file reduce to
UNKNOWN
OFFLINE
SLOW_2G
2G // This fails to compile, and it is also against conventions.
...

[xunjieli, 2016/08/10 17:39:43]

Acknowledged.

 enum EffectiveConnectionType {
   // The connection types should be in increasing order of quality.
   EFFECTIVE_CONNECTION_TYPE_UNKNOWN = 0,
   EFFECTIVE_CONNECTION_TYPE_OFFLINE,
   EFFECTIVE_CONNECTION_TYPE_SLOW_2G,
   EFFECTIVE_CONNECTION_TYPE_2G,
   EFFECTIVE_CONNECTION_TYPE_3G,
   EFFECTIVE_CONNECTION_TYPE_4G,
   EFFECTIVE_CONNECTION_TYPE_BROADBAND,
   EFFECTIVE_CONNECTION_TYPE_LAST,
 };
 
 }  // namespace net
 
 #endif  // NET_NQE_EFFECTIVE_CONNECTION_TYPE_H_