Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/android/java/res/layout/new_tab_page_action_card.xml

Issue 2223743004: 📰 Add an action button that can be used in sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/new_tab_page_action_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_action_card.xml b/chrome/android/java/res/layout/new_tab_page_action_card.xml
new file mode 100644
index 0000000000000000000000000000000000000000..dc0fb40773507b9e50e6f2b7cde6d0ba0a9f65d5
--- /dev/null
+++ b/chrome/android/java/res/layout/new_tab_page_action_card.xml
@@ -0,0 +1,36 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<!-- The Layout takes the regular NTP Card attributes (padding, background
+ drawable) and adds the selectable ripple effects as foreground. The foreground
Bernhard Bauer 2016/08/09 09:02:06 I would align the text in the comment (like in the
dgn 2016/08/09 13:00:42 Done.
+ property requires to use a FrameLayout. -->
+<FrameLayout
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:foreground="?attr/selectableItemBackgroundBorderless"
+ android:clickable="true"
+ android:padding="@dimen/snippets_padding_and_peeking_card_height"
+ android:background="@drawable/ntp_card">
+
+ <!-- We don't use a button here since the effect and the click handler will
+ be done at the parent level, directly on the layout. We transferred select
+ styling properties from ButtonCompatBorderless and made it unfocusable.-->
+ <TextView
+ android:layout_width="wrap_content"
Bernhard Bauer 2016/08/09 09:02:06 Indent two more spaces
dgn 2016/08/09 13:00:42 Done.
+ android:layout_height="wrap_content"
+ android:minHeight="36dp"
+ android:gravity="center_vertical|center_horizontal"
+ android:textSize="15sp"
+ android:paddingStart="8dp"
PEConn 2016/08/08 18:13:12 I think the style guide says that elements that ar
dgn 2016/08/09 13:00:42 Done.
+ android:text="@string/more"
+ android:textAllCaps="true"
+ android:clickable="false"
+ android:focusable="false"
+ android:textStyle="bold"
+ android:textColor="@color/light_active_color"/>
Bernhard Bauer 2016/08/09 09:02:06 Nit: space before closing the tag
dgn 2016/08/09 13:00:42 Done.
+
+</FrameLayout>

Powered by Google App Engine
This is Rietveld 408576698