chrome/android/java/res/layout/new_tab_page_action_card.xml - Issue 2223743004: 📰 Add an action button that can be used in sections

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_action_card.xml

Issue 2223743004: 📰 Add an action button that can be used in sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionListItem.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- The Layout takes the regular NTP Card attributes (padding, background

	7 drawable) and adds the selectable ripple effects as foreground. The foreground
	Bernhard Bauer 2016/08/09 09:02:06 I would align the text in the comment (like in the I would align the text in the comment (like in the copyright notice above). dgn 2016/08/09 13:00:42 Done. Show quoted text On 2016/08/09 09:02:06, Bernhard Bauer wrote: > I would align the text in the comment (like in the copyright notice above). Done.
	8 property requires to use a FrameLayout. -->

	9 <FrameLayout

	10 xmlns:android="http://schemas.android.com/apk/res/android"

	11 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	12 android:layout_width="match_parent"

	13 android:layout_height="wrap_content"

	14 android:foreground="?attr/selectableItemBackgroundBorderless"

	15 android:clickable="true"

	16 android:padding="@dimen/snippets_padding_and_peeking_card_height"

	17 android:background="@drawable/ntp_card">

	18

	19 <!-- We don't use a button here since the effect and the click handler will

	20 be done at the parent level, directly on the layout. We transferred select

	21 styling properties from ButtonCompatBorderless and made it unfocusable.-->

	22 <TextView

	23 android:layout_width="wrap_content"
	Bernhard Bauer 2016/08/09 09:02:06 Indent two more spaces Indent two more spaces dgn 2016/08/09 13:00:42 Done. Show quoted text On 2016/08/09 09:02:06, Bernhard Bauer wrote: > Indent two more spaces Done.
	24 android:layout_height="wrap_content"

	25 android:minHeight="36dp"

	26 android:gravity="center_vertical\|center_horizontal"

	27 android:textSize="15sp"

	28 android:paddingStart="8dp"
	PEConn 2016/08/08 18:13:12 I think the style guide says that elements that ar I think the style guide says that elements that are not id or layout_* should be a alphabetical order. dgn 2016/08/09 13:00:42 Done. Show quoted text On 2016/08/08 18:13:12, PEConn wrote: > I think the style guide says that elements that are not id or layout_* should be > a alphabetical order. Done.
	29 android:text="@string/more"

	30 android:textAllCaps="true"

	31 android:clickable="false"

	32 android:focusable="false"

	33 android:textStyle="bold"

	34 android:textColor="@color/light_active_color"/>
	Bernhard Bauer 2016/08/09 09:02:06 Nit: space before closing the tag Nit: space before closing the tag dgn 2016/08/09 13:00:42 Done. Show quoted text On 2016/08/09 09:02:06, Bernhard Bauer wrote: > Nit: space before closing the tag Done.
	35

	36 </FrameLayout>

OLD	NEW