Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 222353002: Revert of Revert of Early terminate flings when scrolling impossible (Closed)

Created:
6 years, 8 months ago by jdduke (slow)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Revert of Early terminate flings when scrolling impossible (https://codereview.chromium.org/213743004/) Reason for revert: The broken fling layout test has been fixed in: https://codereview.chromium.org/219243010/ Original issue's description: > Revert of Early terminate flings when scrolling impossible (https://codereview.chromium.org/136173004/) > > Reason for revert: > Broke a layout test, fast/events/touch/gesture/pad-gesture-fling.html > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast%2Fevents%2Ftouch%2Fgesture%2Fpad-gesture-fling.html > > > Original issue's description: > > Early terminate flings when scrolling impossible > > > > Previously, flings were terminated early only if the root layer overscrolled. > > Now, flings will terminate if the fling target's |scrollBy()| method returns > > false, providing consistency between layer types and saving battery on > > sites with scrolling sublayers. > > > > Also move |DidOverscrollParams| into content/ in anticipation of using it > > directly in the overscroll IPC message. > > > > Corresponding Blink patch: > > https://codereview.chromium.org/139493003/ > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260631 > > TBR=aelias@chromium.org,jochen@chromium.org,jdduke@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260773 TBR=aelias@chromium.org,jochen@chromium.org,tkent@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -116 lines) Patch
M cc/input/input_handler.h View 3 chunks +2 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +1 line, -18 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fling_animator_impl_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/child/touch_fling_gesture_curve.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/child/touch_fling_gesture_curve_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A content/common/input/did_overscroll_params.h View 1 chunk +20 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_manager.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_proxy.h View 2 chunks +8 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 6 chunks +27 lines, -17 lines 0 comments Download
M content/renderer/input/input_handler_proxy_client.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 7 chunks +51 lines, -20 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_gesture_curve_mock.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/android/scroller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/android/scroller_unittest.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jdduke (slow)
Created Revert of Revert of Early terminate flings when scrolling impossible
6 years, 8 months ago (2014-04-02 15:37:26 UTC) #1
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 8 months ago (2014-04-02 15:37:34 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-02 15:37:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/222353002/1
6 years, 8 months ago (2014-04-02 15:38:46 UTC) #4
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 8 months ago (2014-04-02 19:56:51 UTC) #5
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-02 19:57:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 21:22:34 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60546
6 years, 8 months ago (2014-04-02 21:22:34 UTC) #8
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 8 months ago (2014-04-02 21:41:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/222353002/1
6 years, 8 months ago (2014-04-02 21:44:57 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 21:48:04 UTC) #11
Message was sent while issue was closed.
Change committed as 261187

Powered by Google App Engine
This is Rietveld 408576698