Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2223453003: Thread user gesture through page_load_metrics abort pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 4288ae0a3fa22fa641bf786ed35c8ce1b7e7c817..fb9e29f4e9993fd57f8b371d8462abe0f5d2bd51 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -65,9 +65,11 @@ struct PageLoadExtraInfo {
const base::Optional<base::TimeDelta>& first_background_time,
const base::Optional<base::TimeDelta>& first_foreground_time,
bool started_in_foreground,
+ bool user_gesture,
const GURL& committed_url,
const base::Optional<base::TimeDelta>& time_to_commit,
UserAbortType abort_type,
+ bool abort_user_initiated,
const base::Optional<base::TimeDelta>& time_to_abort,
int num_cache_requests,
int num_network_requests,
@@ -86,6 +88,10 @@ struct PageLoadExtraInfo {
// True if the page load started in the foreground.
const bool started_in_foreground;
+ // True if this is either a browser initiated navigation or the user_gesture
+ // bit is true in the renderer.
+ const bool user_gesture;
+
// Committed URL. If the page load did not commit, |committed_url| will be
// empty.
const GURL committed_url;
@@ -97,6 +103,10 @@ struct PageLoadExtraInfo {
// aborted, |abort_type| will be |ABORT_NONE|.
const UserAbortType abort_type;
+ // TODO(csharrison): If more metadata for aborts is needed we should provide a
+ // better abstraction. Note that this is an approximation.
+ bool abort_user_initiated;
+
const base::Optional<base::TimeDelta> time_to_abort;
// Note: these are only approximations, based on WebContents attribution from

Powered by Google App Engine
This is Rietveld 408576698