Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3584)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 2223453003: Thread user gesture through page_load_metrics abort pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index d60b8cf031ccb7f6d3ddf2f50118cb578f90e045..fd1c420a6c767dde290b1d866699d05f190df7f2 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -190,6 +190,9 @@ const char kHistogramTotalRequestsParseStop[] =
const char kRapporMetricsNameCoarseTiming[] =
"PageLoad.CoarseTiming.NavigationToFirstContentfulPaint";
+const char kHistogramFirstContentfulPaintUserInitiated[] =
+ "PageLoad.PaintTiming.NavigationToFirstContentfulPaint.UserInitiated";
+
const char kHistogramFirstMeaningfulPaintStatus[] =
"PageLoad.Experimental.PaintTiming.FirstMeaningfulPaintStatus";
@@ -325,6 +328,11 @@ void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
timing.first_contentful_paint.value());
}
+ if (info.user_gesture) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintUserInitiated,
+ timing.first_contentful_paint.value());
+ }
+
switch (GetPageLoadType(transition_)) {
case LOAD_TYPE_RELOAD:
PAGE_LOAD_HISTOGRAM(

Powered by Google App Engine
This is Rietveld 408576698