Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2223423004: Split out blimp client build config to its own config.gni file (Closed)

Created:
4 years, 4 months ago by amineer
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2824
Target Ref:
refs/pending/branch-heads/2824
Project:
chromium
Visibility:
Public.

Description

Split out blimp client build config to its own config.gni file Up until now, only GN targets in //blimp/client/core needed to know about the declared argument |enable_blimp_client|. For using the flag in the internal build files though, those .gni-files need to be able to refer to the flag. Since they can not include //blimp/client/core/BUILD.gn, this CL extracts the declaration of the argument into its own .gni-file, that is imported by //blimp/client/core/BUILD.gn. This makes it possible for other GN code to also be able to read the declared argument. BUG=608765 Review-Url: https://codereview.chromium.org/2225233002 Cr-Commit-Position: refs/heads/master@{#410532} (cherry picked from commit 179e0366187c3062f487fe55629872185fb5fb4a) Committed: https://chromium.googlesource.com/chromium/src/+/f17ac022416b6b44e29bb49c5b5f94f7ddcacfbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M blimp/client/core/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
A + blimp/client/core/config.gni View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
amineer
4 years, 4 months ago (2016-08-09 17:53:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f17ac022416b6b44e29bb49c5b5f94f7ddcacfbf.

Powered by Google App Engine
This is Rietveld 408576698