Split out blimp client build config to its own config.gni file

Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765
Committed: https://crrev.com/179e0366187c3062f487fe55629872185fb5fb4a
Cr-Commit-Position: refs/heads/master@{#410532}

[nyquist, 2016-08-08 23:43:28]

nyquist@chromium.org changed reviewers:
+ dpranke@chromium.org

[nyquist, 2016-08-08 23:43:29]

dpranke: PTAL

amineer: FYI

[nyquist, 2016-08-08 23:43:51]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:44:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-08 23:50:34]

The change itself looks fine, but I don't understand "For using the flag on the
scripts on build bots though, those .gni-files need to be able to refer to the
flag.". What "scripts on build bots" are you referring to?

[nyquist, 2016-08-09 00:09:44]

On 2016/08/08 23:50:34, Dirk Pranke wrote:
> The change itself looks fine, but I don't understand "For using the flag on
the
> scripts on build bots though, those .gni-files need to be able to refer to the
> flag.". What "scripts on build bots" are you referring to?

Ah. Sorry.
The flag will be used in the jinja_variables.gni in the internal buildbot.
Currently it's only using the android_channel variable, but the plan is for it
to also do thing depending on the value of enable_blimp_client.

Any suggestion to how I can clarify the CL description to accommodate that?

[nyquist, 2016-08-09 00:12:06]

Description was changed from

==========
Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag on the scripts on build bots though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765
==========

to

==========
Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765
==========

[Dirk Pranke, 2016-08-09 00:12:17]

lgtm, thanks for clarifying.

[nyquist, 2016-08-09 00:12:30]

On 2016/08/09 00:09:44, nyquist wrote:
> On 2016/08/08 23:50:34, Dirk Pranke wrote:
> > The change itself looks fine, but I don't understand "For using the flag on
> the
> > scripts on build bots though, those .gni-files need to be able to refer to
the
> > flag.". What "scripts on build bots" are you referring to?
> 
> Ah. Sorry.
> The flag will be used in the jinja_variables.gni in the internal buildbot.
> Currently it's only using the android_channel variable, but the plan is for it
> to also do thing depending on the value of enable_blimp_client.
> 
> Any suggestion to how I can clarify the CL description to accommodate that?

Changed to "For using the flag in the internal build files though, those ..."
based on offline discussion.

[nyquist, 2016-08-09 00:12:39]

The CQ bit was unchecked by nyquist@chromium.org

[nyquist, 2016-08-09 00:12:43]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:13:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 00:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:57:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nyquist, 2016-08-09 01:05:47]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:06:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 02:24:28]

Description was changed from

==========
Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765
==========

to

==========
Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765
==========

[commit-bot: I haz the power, 2016-08-09 02:24:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 02:28:10]

Description was changed from

==========
Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765
==========

to

==========
Split out blimp client build config to its own config.gni file

Up until now, only GN targets in //blimp/client/core needed to know
about the declared argument |enable_blimp_client|.

For using the flag in the internal build files though, those
.gni-files need to be able to refer to the flag. Since they can not
include //blimp/client/core/BUILD.gn, this CL extracts the declaration
of the argument into its own .gni-file, that is imported by
//blimp/client/core/BUILD.gn.

This makes it possible for other GN code to also be able to read the
declared argument.

BUG=608765

Committed: https://crrev.com/179e0366187c3062f487fe55629872185fb5fb4a
Cr-Commit-Position: refs/heads/master@{#410532}
==========

[commit-bot: I haz the power, 2016-08-09 02:28:12]

Patchset 1 (id:??) landed as
https://crrev.com/179e0366187c3062f487fe55629872185fb5fb4a
Cr-Commit-Position: refs/heads/master@{#410532}