ServiceWorker: DCHECK is changed to CHECK to track the failure

ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.

BUG=634222
Committed: https://crrev.com/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd
Cr-Commit-Position: refs/heads/master@{#410630}

[shimazu, 2016-08-09 06:53:55]

shimazu@chromium.org changed reviewers:
+ nhiroki@chromium.org

[shimazu, 2016-08-09 06:53:56]

ptal ٩( 'ω' )و

[shimazu, 2016-08-09 07:01:36]

Description was changed from

==========
ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.
This check might indicate a potential security bug, so it's better to keep this
change after the bug is solved.

BUG=634222
==========

to

==========
ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.

BUG=634222
==========

[nhiroki, 2016-08-09 07:04:29]

LGTM with a minor comment

https://codereview.chromium.org/2223413002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_provider_host.cc (right):

https://codereview.chromium.org/2223413002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_provider_host.cc:286:
ServiceWorkerUtils::ScopeMatches(registration->pattern(), document_url_));
Can you add a TODO comment like this?

// TODO(shimazu): Change CHECK to DCHECK after https://crbug.com/634222 is
fixed.

[shimazu, 2016-08-09 07:11:27]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2016-08-09 07:11:28]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2223413002/#ps20001
(title: "Add TODO comment")

[commit-bot: I haz the power, 2016-08-09 07:11:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 11:09:34]

Description was changed from

==========
ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.

BUG=634222
==========

to

==========
ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.

BUG=634222
==========

[commit-bot: I haz the power, 2016-08-09 11:09:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 11:11:16]

Description was changed from

==========
ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.

BUG=634222
==========

to

==========
ServiceWorker: DCHECK is changed to CHECK to track the failure

This patch is to figure the cause of failure out by the crash dashboard.

BUG=634222

Committed: https://crrev.com/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd
Cr-Commit-Position: refs/heads/master@{#410630}
==========

[commit-bot: I haz the power, 2016-08-09 11:11:17]

Patchset 2 (id:??) landed as
https://crrev.com/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd
Cr-Commit-Position: refs/heads/master@{#410630}

[shimazu, 2016-08-15 05:54:07]

Patchset #3 (id:40001) has been deleted