Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2223413002: ServiceWorker: DCHECK is changed to CHECK to track the failure (Closed)

Created:
4 years, 4 months ago by shimazu
Modified:
4 years, 4 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: DCHECK is changed to CHECK to track the failure This patch is to figure the cause of failure out by the crash dashboard. BUG=634222 Committed: https://crrev.com/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd Cr-Commit-Position: refs/heads/master@{#410630}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
shimazu
ptal ٩( 'ω' )و
4 years, 4 months ago (2016-08-09 06:53:56 UTC) #2
nhiroki
LGTM with a minor comment https://codereview.chromium.org/2223413002/diff/1/content/browser/service_worker/service_worker_provider_host.cc File content/browser/service_worker/service_worker_provider_host.cc (right): https://codereview.chromium.org/2223413002/diff/1/content/browser/service_worker/service_worker_provider_host.cc#newcode286 content/browser/service_worker/service_worker_provider_host.cc:286: ServiceWorkerUtils::ScopeMatches(registration->pattern(), document_url_)); Can you ...
4 years, 4 months ago (2016-08-09 07:04:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223413002/20001
4 years, 4 months ago (2016-08-09 07:11:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 11:09:35 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 11:11:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd
Cr-Commit-Position: refs/heads/master@{#410630}

Powered by Google App Engine
This is Rietveld 408576698