Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 2223413002: ServiceWorker: DCHECK is changed to CHECK to track the failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index c914a550c9181138c4a0f56ec68b8da62c36d646..fe9cd8b4e1dd91a850d1c936cd2c9a1f8b80d8e4 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -282,8 +282,10 @@ void ServiceWorkerProviderHost::DisassociateRegistration() {
void ServiceWorkerProviderHost::AddMatchingRegistration(
ServiceWorkerRegistration* registration) {
- DCHECK(ServiceWorkerUtils::ScopeMatches(
- registration->pattern(), document_url_));
+ // TODO(shimazu): Change CHECK to DCHECK after https://crbug.com/634222 is
+ // fixed.
+ CHECK(
+ ServiceWorkerUtils::ScopeMatches(registration->pattern(), document_url_));
if (!IsContextSecureForServiceWorker())
return;
size_t key = registration->pattern().spec().size();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698