Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2223353003: Disable MetricsServiceBrowserTest.CrashRenderers on Windows (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MetricsServiceBrowserTest.CrashRenderers on Windows The final DCHECK in MetricsStateManager::LoadClientInfoAndMaybeMigrate is failing flakily. BUG=635770 TBR=asvitkine@chromium.org Committed: https://crrev.com/a5445ce1c75599a59781e686303627dfa468e47a Cr-Commit-Position: refs/heads/master@{#410613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/metrics/metrics_service_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
foolip
Committed patchset #1 (id:1) to pending queue manually as 48388a4ff455641224d7eb9df2d7972c5f45f295 (presubmit successful).
4 years, 4 months ago (2016-08-09 08:15:34 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a5445ce1c75599a59781e686303627dfa468e47a Cr-Commit-Position: refs/heads/master@{#410613}
4 years, 4 months ago (2016-08-09 08:17:23 UTC) #3
Alexei Svitkine (slow)
4 years, 4 months ago (2016-08-13 00:15:36 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2245483006/ by asvitkine@chromium.org.

The reason for reverting is: Re-enabling test given the underlying issue has
been fixed..

Powered by Google App Engine
This is Rietveld 408576698