Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2223253003: Remove OfflinePageUtils::GetOfflineURLForOnlineURL (Closed)

Created:
4 years, 4 months ago by jianli
Modified:
4 years, 4 months ago
Reviewers:
fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OfflinePageUtils::GetOfflineURLForOnlineURL This is not longer used. BUG=none Committed: https://crrev.com/9e2e2f5abbcb097e490f044c7e2b71bc591e65d6 Cr-Commit-Position: refs/heads/master@{#410533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M chrome/browser/android/offline_pages/offline_page_utils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_utils_unittest.cc View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jianli
4 years, 4 months ago (2016-08-08 22:42:13 UTC) #2
fgorski
lgtm
4 years, 4 months ago (2016-08-08 23:08:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223253003/1
4 years, 4 months ago (2016-08-09 00:32:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 02:25:15 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 02:28:13 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9e2e2f5abbcb097e490f044c7e2b71bc591e65d6
Cr-Commit-Position: refs/heads/master@{#410533}

Powered by Google App Engine
This is Rietveld 408576698