Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2223253003: Remove OfflinePageUtils::GetOfflineURLForOnlineURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
index c46dcea11a1a2dcf0871e09c9464c3e05f5dd732..64f3fe36a63f9df3524a5ee27d5ba9b261ac33e4 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
@@ -53,7 +53,6 @@ class OfflinePageUtilsTest
void SetUp() override;
void RunUntilIdle();
- GURL GetOfflineURLForOnlineURL(GURL online_url);
// Necessary callbacks for the offline page model.
void OnSavePageDone(SavePageResult result, int64_t offlineId);
@@ -142,14 +141,6 @@ void OfflinePageUtilsTest::OnGetURLDone(const GURL& url) {
url_ = url;
}
-GURL OfflinePageUtilsTest::GetOfflineURLForOnlineURL(GURL online_url) {
- OfflinePageUtils::GetOfflineURLForOnlineURL(
- profile(), online_url,
- base::Bind(&OfflinePageUtilsTest::OnGetURLDone, AsWeakPtr()));
- RunUntilIdle();
- return url_;
-}
-
void OfflinePageUtilsTest::SetLastPathCreatedByArchiver(
const base::FilePath& file_path) {}
@@ -226,17 +217,6 @@ TEST_F(OfflinePageUtilsTest, MightBeOfflineURL) {
EXPECT_TRUE(OfflinePageUtils::MightBeOfflineURL(GURL("file:///test.mhtml")));
}
-TEST_F(OfflinePageUtilsTest, GetOfflineURLForOnlineURL) {
- EXPECT_EQ(offline_url_page_1(),
- OfflinePageUtilsTest::GetOfflineURLForOnlineURL(kTestPage1Url));
- EXPECT_EQ(offline_url_page_2(),
- OfflinePageUtilsTest::GetOfflineURLForOnlineURL(kTestPage2Url));
- EXPECT_EQ(GURL::EmptyGURL(),
- OfflinePageUtilsTest::GetOfflineURLForOnlineURL(kTestPage3Url));
- EXPECT_EQ(GURL::EmptyGURL(),
- OfflinePageUtilsTest::GetOfflineURLForOnlineURL(kTestPage4Url));
-}
-
TEST_F(OfflinePageUtilsTest, MaybeGetOnlineURLForOfflineURL) {
EXPECT_EQ(kTestPage1Url, OfflinePageUtils::MaybeGetOnlineURLForOfflineURL(
profile(), offline_url_page_1()));
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698