Remove "< 7 minutes system startup" from startup metrics.

Remove "< 7 minutes system startup" from startup metrics.

Record these histograms all the time instead of only after 7 minutes
of OS uptime:
- Startup.LoadTime.ExeMainToDllMain
- Startup.LoadTime.ProcessCreateToDllMain
- Startup.LoadTime.ProcessCreateToExeMain
- Startup.BrowserMessageLoopStartTimeFromMainEntry
- Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun

Note: A version of these histograms recorded after 7 minutes of OS
uptime is kept for now to allow regressions to be caught reliably.

BUG=634408
Committed: https://crrev.com/0a804c57f2814605540ef11db5187fb94cf359d8
Cr-Commit-Position: refs/heads/master@{#413746}

[fdoray, 2016-08-08 19:46:56]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, rkaplow@chromium.org

[fdoray, 2016-08-08 19:46:56]

PTAL

[rkaplow, 2016-08-08 19:51:20]

lgtm

[gab, 2016-08-10 16:45:35]

lgtm w/ nits

https://codereview.chromium.org/2223183002/diff/40001/components/startup_metr...
File components/startup_metric_utils/browser/startup_metric_utils.cc (right):

https://codereview.chromium.org/2223183002/diff/40001/components/startup_metr...
components/startup_metric_utils/browser/startup_metric_utils.cc:613: //
regressions to be caught reliably. crbug.com/634408
s/reliably/reliably in M54, to be removed in M55/

or M55/M56 (depending on when you land this)

https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56194: +  </obsolete>
Do not mark as obsolete yet (otherwise no point recording them as they won't be
visible -- unless you really only want to be able to manually find them by
typing their full name without autocomplete? I could buy that given it's more
likely to cause confusion than help, merely keeping them accessible without
auto-complete might be better)

Rob?

https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56224: + 
<owner>jeremy@chromium.org</owner>
Ask them as FYI but I think proper modern owners for these are you and I (jeremy
no longer works on startup and csharp merely took ownership of a bunch of them
during early protector days IIRC so that we wouldn't lose track of things that
*could* matter back when metrics team introduced "no owner == obsolete").

Similarly, feel free to modify owners for all other Startup.* metrics (you/I
everywhere +erikchen on the ones he added).

[rkaplow, 2016-08-10 17:30:17]

On 2016/08/10 16:45:35, gab wrote:
> lgtm w/ nits
> 
>
https://codereview.chromium.org/2223183002/diff/40001/components/startup_metr...
> File components/startup_metric_utils/browser/startup_metric_utils.cc (right):
> 
>
https://codereview.chromium.org/2223183002/diff/40001/components/startup_metr...
> components/startup_metric_utils/browser/startup_metric_utils.cc:613: //
> regressions to be caught reliably. crbug.com/634408
> s/reliably/reliably in M54, to be removed in M55/
> 
> or M55/M56 (depending on when you land this)
> 
>
https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:56194: +  </obsolete>
> Do not mark as obsolete yet (otherwise no point recording them as they won't
be
> visible -- unless you really only want to be able to manually find them by
> typing their full name without autocomplete? I could buy that given it's more
> likely to cause confusion than help, merely keeping them accessible without
> auto-complete might be better)
> 
> Rob?
> 
>
https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:56224: + 
> <mailto:owner>jeremy@chromium.org</owner>
> Ask them as FYI but I think proper modern owners for these are you and I
(jeremy
> no longer works on startup and csharp merely took ownership of a bunch of them
> during early protector days IIRC so that we wouldn't lose track of things that
> *could* matter back when metrics team introduced "no owner == obsolete").
> 
> Similarly, feel free to modify owners for all other Startup.* metrics (you/I
> everywhere +erikchen on the ones he added).

All makes sense to me. So let's keep unobsolete for now, and put the information
you put there in the description

[fdoray, 2016-08-23 14:50:17]

cc: jeremy@: FYI, gab and I are taking ownership of some startup histograms that
you owned

https://codereview.chromium.org/2223183002/diff/40001/components/startup_metr...
File components/startup_metric_utils/browser/startup_metric_utils.cc (right):

https://codereview.chromium.org/2223183002/diff/40001/components/startup_metr...
components/startup_metric_utils/browser/startup_metric_utils.cc:613: //
regressions to be caught reliably. crbug.com/634408
On 2016/08/10 16:45:35, gab (OOO Aug 15 - Sep 1) wrote:
> s/reliably/reliably in M54, to be removed in M55/
> 
> or M55/M56 (depending on when you land this)

Done.

https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56194: +  </obsolete>
On 2016/08/10 16:45:35, gab (OOO Aug 15 - Sep 1) wrote:
> Do not mark as obsolete yet (otherwise no point recording them as they won't
be
> visible -- unless you really only want to be able to manually find them by
> typing their full name without autocomplete? I could buy that given it's more
> likely to cause confusion than help, merely keeping them accessible without
> auto-complete might be better)
> 
> Rob?

Done.

https://codereview.chromium.org/2223183002/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:56224: + 
<owner>jeremy@chromium.org</owner>
On 2016/08/10 16:45:35, gab (OOO Aug 15 - Sep 1) wrote:
> Ask them as FYI but I think proper modern owners for these are you and I
(jeremy
> no longer works on startup and csharp merely took ownership of a bunch of them
> during early protector days IIRC so that we wouldn't lose track of things that
> *could* matter back when metrics team introduced "no owner == obsolete").
> 
> Similarly, feel free to modify owners for all other Startup.* metrics (you/I
> everywhere +erikchen on the ones he added).

Done.

[fdoray, 2016-08-23 14:50:55]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-08-23 14:50:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2223183002/#ps80001
(title: "add reference to bug")

[commit-bot: I haz the power, 2016-08-23 14:51:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 15:50:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-23 15:53:51]

Description was changed from

==========
Remove "< 7 minutes system startup" from startup metrics.

Record these histograms all the time instead of only after 7 minutes
of OS uptime:
- Startup.LoadTime.ExeMainToDllMain
- Startup.LoadTime.ProcessCreateToDllMain
- Startup.LoadTime.ProcessCreateToExeMain
- Startup.BrowserMessageLoopStartTimeFromMainEntry
- Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun

Note: A version of these histograms recorded after 7 minutes of OS
uptime is kept for now to allow regressions to be caught reliably.

BUG=634408
==========

to

==========
Remove "< 7 minutes system startup" from startup metrics.

Record these histograms all the time instead of only after 7 minutes
of OS uptime:
- Startup.LoadTime.ExeMainToDllMain
- Startup.LoadTime.ProcessCreateToDllMain
- Startup.LoadTime.ProcessCreateToExeMain
- Startup.BrowserMessageLoopStartTimeFromMainEntry
- Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun

Note: A version of these histograms recorded after 7 minutes of OS
uptime is kept for now to allow regressions to be caught reliably.

BUG=634408

Committed: https://crrev.com/0a804c57f2814605540ef11db5187fb94cf359d8
Cr-Commit-Position: refs/heads/master@{#413746}
==========

[commit-bot: I haz the power, 2016-08-23 15:53:51]

Patchset 5 (id:??) landed as
https://crrev.com/0a804c57f2814605540ef11db5187fb94cf359d8
Cr-Commit-Position: refs/heads/master@{#413746}