Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2223183002: Remove "< 7 minutes system startup" from startup metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add reference to bug Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/startup_metric_utils/browser/startup_metric_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index dd8319181bcd39a7f7132964109ad2fd21cece9d..fcfd07717175bf8b5db60310bc9333d6e826895f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -57069,23 +57069,46 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry" units="ms">
- <owner>jeremy@chromium.org</owner>
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
<summary>
Time from main entry to the start of the main thread's message loop. This
stat is only recorded after 7 minutes of OS uptime to try to mitigate the
- variance resulting from Chrome being autostarted.
+ variance resulting from Chrome being autostarted. Replaced with
+ Startup.BrowserMessageLoopStartTimeFromMainEntry2 which is recorded all the
+ time. TODO(fdoray): Deprecate this once M54 hits stable. crbug.com/634408
</summary>
</histogram>
<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun"
units="ms">
- <owner>csharp@chromium.org</owner>
+ <owner>fdoray@chromium.org</owner>
<owner>gab@chromium.org</owner>
- <owner>jeremy@chromium.org</owner>
<summary>
Time from main entry to the start of the main thread's message loop on first
run. This stat is only recorded after 7 minutes of OS uptime to try to
- mitigate the variance resulting from Chrome being autostarted.
+ mitigate the variance resulting from Chrome being autostarted. Replaced with
+ Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun2 which is recorded
+ all the time. TODO(fdoray): Deprecate this once M54 hits stable.
+ crbug.com/634408
+ </summary>
+</histogram>
+
+<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun2"
+ units="ms">
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
+ <summary>
+ Time from main entry to the start of the main thread's message loop on first
+ run.
+ </summary>
+</histogram>
+
+<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry2" units="ms">
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
+ <summary>
+ Time from main entry to the start of the main thread's message loop.
</summary>
</histogram>
@@ -57388,29 +57411,61 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="Startup.LoadTime.ExeMainToDllMain">
- <owner>jeremy@chromium.org</owner>
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
<summary>
Time from the main() function in chrome.exe to chrome.dll's main(). This
stat is only recorded after 7 minutes of OS uptime to try to mitigate the
- variance resulting from Chrome being autostarted.
+ variance resulting from Chrome being autostarted. Replaced with
+ Startup.LoadTime.ExeMainToDllMain2 which is recorded all the time.
+ TODO(fdoray): Deprecate this once M54 hits stable. crbug.com/634408
+ </summary>
+</histogram>
+
+<histogram name="Startup.LoadTime.ExeMainToDllMain2">
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
+ <summary>
+ Time from the main() function in chrome.exe to chrome.dll's main().
</summary>
</histogram>
<histogram name="Startup.LoadTime.ProcessCreateToDllMain">
- <owner>jeremy@chromium.org</owner>
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
<summary>
Time from the process creation to chrome.dll's main(). This stat is only
recorded after 7 minutes of OS uptime to try to mitigate the variance
- resulting from Chrome being autostarted.
+ resulting from Chrome being autostarted. Replaced with
+ Startup.LoadTime.ProcessCreateToDllMain2 which is recorded all the time.
+ TODO(fdoray): Deprecate this once M54 hits stable. crbug.com/634408
</summary>
</histogram>
+<histogram name="Startup.LoadTime.ProcessCreateToDllMain2">
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
+ <summary>Time from the process creation to chrome.dll's main().</summary>
+</histogram>
+
<histogram name="Startup.LoadTime.ProcessCreateToExeMain">
- <owner>jeremy@chromium.org</owner>
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
<summary>
Time from the process creation to executing the main() function in
chrome.exe. This stat is only recorded after 7 minutes of OS uptime to try
- to mitigate the variance resulting from Chrome being autostarted.
+ to mitigate the variance resulting from Chrome being autostarted. Replaced
+ with Startup.LoadTime.ProcessCreateToExeMain2 which is recorded all the
+ time. TODO(fdoray): Deprecate this once M54 hits stable. crbug.com/634408
+ </summary>
+</histogram>
+
+<histogram name="Startup.LoadTime.ProcessCreateToExeMain2">
+ <owner>fdoray@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
+ <summary>
+ Time from the process creation to executing the main() function in
+ chrome.exe.
</summary>
</histogram>
@@ -102957,6 +103012,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.BrowserMessageLoopStartHardFaultCount"/>
<affected-histogram name="Startup.BrowserMessageLoopStartTime"/>
<affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry"/>
+ <affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry2"/>
<affected-histogram name="Startup.BrowserOpenTabs"/>
<affected-histogram name="Startup.BrowserWindowDisplay"/>
<affected-histogram name="Startup.FirstWebContents.MainFrameLoad2"/>
@@ -102964,8 +103020,11 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.FirstWebContents.MainNavigationStart"/>
<affected-histogram name="Startup.FirstWebContents.NonEmptyPaint2"/>
<affected-histogram name="Startup.LoadTime.ExeMainToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ExeMainToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain2"/>
<affected-histogram name="Startup.SystemUptime"/>
<affected-histogram name="Startup.Temperature"/>
<affected-histogram name="Startup.TimeSinceLastStartup"/>
@@ -103560,6 +103619,9 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry"/>
<affected-histogram
name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun"/>
+ <affected-histogram
+ name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun2"/>
+ <affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry2"/>
<affected-histogram name="Startup.BrowserOpenTabs"/>
<affected-histogram name="Startup.BrowserWindowDisplay"/>
<affected-histogram name="Startup.FirstWebContents.MainFrameLoad"/>
@@ -103569,8 +103631,11 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.FirstWebContents.NonEmptyPaint"/>
<affected-histogram name="Startup.FirstWebContents.NonEmptyPaint2"/>
<affected-histogram name="Startup.LoadTime.ExeMainToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ExeMainToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain2"/>
<affected-histogram name="Startup.SystemUptime"/>
<affected-histogram name="Startup.TimeSinceLastStartup"/>
</histogram_suffixes>
« no previous file with comments | « components/startup_metric_utils/browser/startup_metric_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698