Removed Wrap-Flow and Wrap-Through from ComputedStyle

Removed Wrap-Flow and Wrap-Through from ComputedStyle

Removed Wrap-Flow and Wrap-Through from ComputedStyle's
StyleRareInheritedData, since they are no longer used. Also removed some
additional unused ComputedStyle initial value methods.

BUG=628043
Committed: https://crrev.com/040825f25fe910d965b7f1a7521f6f4efa3ef6c4
Cr-Commit-Position: refs/heads/master@{#412757}

[sashab, 2016-08-09 07:06:55]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[sashab, 2016-08-09 07:07:14]

sashab@chromium.org changed reviewers:
+ rjwright@chromium.org

[commit-bot: I haz the power, 2016-08-09 07:07:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 09:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 09:09:44]

Dry run: This issue passed the CQ dry run.

[rjwright, 2016-08-10 06:43:54]

On 2016/08/09 07:07:14, sashab wrote:

LGTM with comments

[rjwright, 2016-08-10 06:44:13]

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (left):

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:1235: static WrapThrough
initialWrapThrough() { return WrapThroughWrap; }
Remove wrapflow & wrapthrough enums?

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:2373: static
ImageResolutionSnap initialImageResolutionSnap() { return ImageResolutionNoSnap;
}
Can we also remove ImageResolutionSource and ImageResolutionSnap enums?

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:1231: // will-change
are these comments still needed?

[sashab, 2016-08-11 07:33:16]

sashab@chromium.org changed reviewers:
+ dstockwell@chromium.org

[sashab, 2016-08-11 07:33:16]

Thanks for finding all those renee!! Doug for owners. :)

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (left):

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:1235: static WrapThrough
initialWrapThrough() { return WrapThroughWrap; }
On 2016/08/10 at 06:44:13, rjwright wrote:
> Remove wrapflow & wrapthrough enums?

Done.

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:2373: static
ImageResolutionSnap initialImageResolutionSnap() { return ImageResolutionNoSnap;
}
On 2016/08/10 at 06:44:13, rjwright wrote:
> Can we also remove ImageResolutionSource and ImageResolutionSnap enums?

Done!

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2223133004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.h:1231: // will-change
On 2016/08/10 at 06:44:13, rjwright wrote:
> are these comments still needed?

Yup, these are describing the property the methods below it are for.

[Timothy Loh, 2016-08-12 05:45:50]

timloh@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-08-12 05:45:50]

lgtm

https://codereview.chromium.org/2223133004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2223133004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.h:1230: // Exclusions
properties.
stale comment

[sashab, 2016-08-18 04:51:05]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-08-18 04:51:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjwright@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2223133004/#ps40001
(title: "Removed stale comment and rebase")

[commit-bot: I haz the power, 2016-08-18 04:51:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 06:23:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-18 06:26:43]

Description was changed from

==========
Removed Wrap-Flow and Wrap-Through from ComputedStyle

Removed Wrap-Flow and Wrap-Through from ComputedStyle's
StyleRareInheritedData, since they are no longer used. Also removed some
additional unused ComputedStyle initial value methods.

BUG=628043
==========

to

==========
Removed Wrap-Flow and Wrap-Through from ComputedStyle

Removed Wrap-Flow and Wrap-Through from ComputedStyle's
StyleRareInheritedData, since they are no longer used. Also removed some
additional unused ComputedStyle initial value methods.

BUG=628043

Committed: https://crrev.com/040825f25fe910d965b7f1a7521f6f4efa3ef6c4
Cr-Commit-Position: refs/heads/master@{#412757}
==========

[commit-bot: I haz the power, 2016-08-18 06:26:44]

Patchset 3 (id:??) landed as
https://crrev.com/040825f25fe910d965b7f1a7521f6f4efa3ef6c4
Cr-Commit-Position: refs/heads/master@{#412757}