Removed Wrap-Flow and Wrap-Through from ComputedStyle

third_party/WebKit/Source/core/style/ComputedStyle.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 1210 matching lines @@
     void setUnicodeBidi(EUnicodeBidi b) { m_nonInheritedData.m_unicodeBidi = b; }
 
     // vertical-align
     static EVerticalAlign initialVerticalAlign() { return VerticalAlignBaseline; }
     EVerticalAlign verticalAlign() const { return static_cast<EVerticalAlign>(m_nonInheritedData.m_verticalAlign); }
     const Length& getVerticalAlignLength() const { return m_box->verticalAlign(); }
     void setVerticalAlign(EVerticalAlign v) { m_nonInheritedData.m_verticalAlign = v; }
     void setVerticalAlignLength(const Length& length) { setVerticalAlign(VerticalAlignLength); SET_VAR(m_box, m_verticalAlign, length); }
 
     // Exclusions properties.
-    // wrap-flow
-    static WrapFlow initialWrapFlow() { return WrapFlowAuto; }
-
-    // wrap-through
-    static WrapThrough initialWrapThrough() { return WrapThroughWrap; }

[rjwright, 2016/08/10 06:44:13]

Remove wrapflow & wrapthrough enums?

[sashab, 2016/08/11 07:33:16]

Done.

-
     // will-change

[rjwright, 2016/08/10 06:44:13]

are these comments still needed?

[sashab, 2016/08/11 07:33:16]

Yup, these are describing the property the methods below it are for.

     const Vector<CSSPropertyID>& willChangeProperties() const { return m_rareNonInheritedData->m_willChange->m_properties; }
     bool willChangeContents() const { return m_rareNonInheritedData->m_willChange->m_contents; }
     bool willChangeScrollPosition() const { return m_rareNonInheritedData->m_willChange->m_scrollPosition; }
     bool subtreeWillChangeContents() const { return m_rareInheritedData->m_subtreeWillChangeContents; }
     void setWillChangeProperties(const Vector<CSSPropertyID>& properties) { SET_NESTED_VAR(m_rareNonInheritedData, m_willChange, m_properties, properties); }
     void setWillChangeContents(bool b) { SET_NESTED_VAR(m_rareNonInheritedData, m_willChange, m_contents, b); }
     void setWillChangeScrollPosition(bool b) { SET_NESTED_VAR(m_rareNonInheritedData, m_willChange, m_scrollPosition, b); }
     void setSubtreeWillChangeContents(bool b) { SET_VAR(m_rareInheritedData, m_subtreeWillChangeContents, b); }
 
     // z-index
@@ skipping 1112 matching lines @@
     // TODO(sashab): Rename this to just getColor(), and add a comment explaining how it works.
     Color visitedDependentColor(int colorProperty) const;
 
     // -webkit-appearance utility functions.
     bool hasAppearance() const { return appearance() != NoControlPart; }
 
     // Other utility functions.
     bool isStyleAvailable() const;
     bool isSharable() const;
 
-    // TODO(sashab) Remove these.
-    static ImageOrientationEnum initialImageOrientation() { return OriginTopLeft; }
-    static ImageResolutionSource initialImageResolutionSource() { return ImageResolutionSpecified; }
-    static ImageResolutionSnap initialImageResolutionSnap() { return ImageResolutionNoSnap; }

[rjwright, 2016/08/10 06:44:13]

Can we also remove ImageResolutionSource and ImageResolutionSnap enums?

[sashab, 2016/08/11 07:33:16]

Done!

-    static float initialImageResolution() { return 1; }
-    void setWrapFlow(WrapFlow wrapFlow) { SET_VAR(m_rareNonInheritedData, m_wrapFlow, wrapFlow); }
-    void setWrapThrough(WrapThrough wrapThrough) { SET_VAR(m_rareNonInheritedData, m_wrapThrough, wrapThrough); }
-
 private:
     void setVisitedLinkColor(const Color&);
     void setVisitedLinkBackgroundColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkBackgroundColor, v); }
     void setVisitedLinkBorderLeftColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkBorderLeftColor, v); }
     void setVisitedLinkBorderRightColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkBorderRightColor, v); }
     void setVisitedLinkBorderBottomColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkBorderBottomColor, v); }
     void setVisitedLinkBorderTopColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkBorderTopColor, v); }
     void setVisitedLinkOutlineColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkOutlineColor, v); }
     void setVisitedLinkColumnRuleColor(const StyleColor& v) { SET_NESTED_VAR(m_rareNonInheritedData, m_multiCol, m_visitedLinkColumnRuleColor, v); }
     void setVisitedLinkTextDecorationColor(const StyleColor& v) { SET_VAR(m_rareNonInheritedData, m_visitedLinkTextDecorationColor, v); }
@@ skipping 166 matching lines @@
 }
 
 inline bool ComputedStyle::hasPseudoElementStyle() const
 {
     return m_nonInheritedData.m_pseudoBits & ElementPseudoIdMask;
 }
 
 } // namespace blink
 
 #endif // ComputedStyle_h