[Profiles] Download high-res avatars using the --new-profile-management flag

chrome/browser/ui/startup/startup_browser_creator.cc

Index: chrome/browser/ui/startup/startup_browser_creator.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc
index c22ed679742335719190f32a5d9f17b1421f2c1c..8d8700e1e4c4255ae429e6a641fff7c079da3bd0 100644
--- a/chrome/browser/ui/startup/startup_browser_creator.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator.cc
@@ -272,6 +272,15 @@ bool StartupBrowserCreator::LaunchBrowser(
     chrome::startup::IsFirstRun is_first_run,
     int* return_code) {
 
+  // If needed, start downloading the high-res avatar.

[msw, 2014/04/28 20:46:37]

Is this actually needed on browser launch? Is there a better profile/UI
initialization codepath to start this task? I don't think I'd be comfortable
approving this change as-is.

[noms (inactive), 2014/04/29 19:12:27]

You're right, now that the ProfileInfoCache can create an AvatarDownloader, it
doesn't need to be here. Done.
On 2014/04/28 20:46:37, msw wrote:

+  if (switches::IsNewAvatarMenu()) {
+    ProfileInfoCache& cache =
+        g_browser_process->profile_manager()->GetProfileInfoCache();
+    size_t profile_index = cache.GetIndexOfProfileWithPath(profile->GetPath());
+    size_t icon_index = cache.GetAvatarIconIndexOfProfileAtIndex(profile_index);
+    profiles::DownloadHighResAvatarIfNeeded(icon_index);
+  }
+
   in_synchronous_profile_launch_ =
       process_startup == chrome::startup::IS_PROCESS_STARTUP;
   DCHECK(profile);