[Profiles] Download high-res avatars using the --new-profile-management flag

chrome/browser/ui/startup/startup_browser_creator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 
 #include <algorithm>   // For max().
 #include <set>
 
 #include "apps/app_load_service.h"
@@ skipping 254 matching lines @@
 }
 
 bool StartupBrowserCreator::LaunchBrowser(
     const CommandLine& command_line,
     Profile* profile,
     const base::FilePath& cur_dir,
     chrome::startup::IsProcessStartup process_startup,
     chrome::startup::IsFirstRun is_first_run,
     int* return_code) {
 
+  // If needed, start downloading the high-res avatar.

[msw, 2014/04/28 20:46:37]

Is this actually needed on browser launch? Is there a better profile/UI
initialization codepath to start this task? I don't think I'd be comfortable
approving this change as-is.

[noms (inactive), 2014/04/29 19:12:27]

You're right, now that the ProfileInfoCache can create an AvatarDownloader, it
doesn't need to be here. Done.
On 2014/04/28 20:46:37, msw wrote:

+  if (switches::IsNewAvatarMenu()) {
+    ProfileInfoCache& cache =
+        g_browser_process->profile_manager()->GetProfileInfoCache();
+    size_t profile_index = cache.GetIndexOfProfileWithPath(profile->GetPath());
+    size_t icon_index = cache.GetAvatarIconIndexOfProfileAtIndex(profile_index);
+    profiles::DownloadHighResAvatarIfNeeded(icon_index);
+  }
+
   in_synchronous_profile_launch_ =
       process_startup == chrome::startup::IS_PROCESS_STARTUP;
   DCHECK(profile);
 
   // Continue with the incognito profile from here on if Incognito mode
   // is forced.
   if (IncognitoModePrefs::ShouldLaunchIncognito(command_line,
                                                 profile->GetPrefs())) {
     profile = profile->GetOffTheRecordProfile();
   } else if (command_line.HasSwitch(switches::kIncognito)) {
@@ skipping 440 matching lines @@
   }
 
   if (command_line.HasSwitch(switches::kProfileDirectory)) {
     return user_data_dir.Append(
         command_line.GetSwitchValuePath(switches::kProfileDirectory));
   }
 
   return g_browser_process->profile_manager()->GetLastUsedProfileDir(
       user_data_dir);
 }