Add line starts into unlinked units.

Add line starts into unlinked units.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/b3588f44fe22f6e43898e331798ca0d5239b88d3

[Brian Wilkerson, 2016-08-08 17:25:36]

lgtm

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/source.dart:320: int get lineCount =>
lineStarts.length;
Or just remove this method, given that it's already implemented in the
superclass. We could also deprecate and remove references to this class, but I'd
do that in a separate CL.

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer_cli/lib/src/bu...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer_cli/lib/src/bu...
pkg/analyzer_cli/lib/src/build_mode.dart:364: serializeAstUnlinked(unit,
lineInfo.lineStarts);
This code appears to be a duplicate of the code you modified in
pkg/analyzer/lib/src/summary/summarize_elements.dart. At some point (not
necessarily in this CL) it would be good to remove the duplication.

[scheglov, 2016-08-08 17:47:32]

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/source.dart:320: int get lineCount =>
lineStarts.length;
On 2016/08/08 17:25:35, Brian Wilkerson wrote:
> Or just remove this method, given that it's already implemented in the
> superclass. We could also deprecate and remove references to this class, but
I'd
> do that in a separate CL.

I removed the method.

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer_cli/lib/src/bu...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/2223113002/diff/1/pkg/analyzer_cli/lib/src/bu...
pkg/analyzer_cli/lib/src/build_mode.dart:364: serializeAstUnlinked(unit,
lineInfo.lineStarts);
On 2016/08/08 17:25:35, Brian Wilkerson wrote:
> This code appears to be a duplicate of the code you modified in
> pkg/analyzer/lib/src/summary/summarize_elements.dart. At some point (not
> necessarily in this CL) it would be good to remove the duplication.

Hm... I don't see code duplication between this file and
pkg/analyzer/lib/src/summary/summarize_elements.dart.

[Paul Berry, 2016-08-08 18:38:10]

lgtm

https://codereview.chromium.org/2223113002/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/2223113002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/summarize_elements.dart:455:
compilationUnit.context?.computeLineInfo(unitSource)?.lineStarts ??
Nit: the `?? const <int>[]` isn't necessary.  The default value of the field
(which is the empty list) should automatically be used if you try to assign
`null`.

[scheglov, 2016-08-08 18:40:12]

Description was changed from

==========
Add line starts into unlinked units.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add line starts into unlinked units.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/b3588f44fe22f6e43898e331798ca0d5239b88d3
==========

[scheglov, 2016-08-08 18:40:14]

Committed patchset #2 (id:20001) manually as
b3588f44fe22f6e43898e331798ca0d5239b88d3 (presubmit successful).