Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: pkg/analyzer/lib/src/summary/summarize_elements.dart

Issue 2223113002: Add line starts into unlinked units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: tweaks Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library serialization.elements; 5 library serialization.elements;
6 6
7 import 'dart:convert'; 7 import 'dart:convert';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/element/element.dart'; 10 import 'package:analyzer/dart/element/element.dart';
11 import 'package:analyzer/dart/element/type.dart'; 11 import 'package:analyzer/dart/element/type.dart';
12 import 'package:analyzer/src/dart/element/element.dart'; 12 import 'package:analyzer/src/dart/element/element.dart';
13 import 'package:analyzer/src/dart/element/member.dart'; 13 import 'package:analyzer/src/dart/element/member.dart';
14 import 'package:analyzer/src/dart/element/type.dart'; 14 import 'package:analyzer/src/dart/element/type.dart';
15 import 'package:analyzer/src/generated/java_engine.dart';
15 import 'package:analyzer/src/generated/resolver.dart'; 16 import 'package:analyzer/src/generated/resolver.dart';
16 import 'package:analyzer/src/generated/source.dart'; 17 import 'package:analyzer/src/generated/source.dart';
17 import 'package:analyzer/src/generated/utilities_dart.dart'; 18 import 'package:analyzer/src/generated/utilities_dart.dart';
18 import 'package:analyzer/src/summary/api_signature.dart'; 19 import 'package:analyzer/src/summary/api_signature.dart';
19 import 'package:analyzer/src/summary/format.dart'; 20 import 'package:analyzer/src/summary/format.dart';
20 import 'package:analyzer/src/summary/idl.dart'; 21 import 'package:analyzer/src/summary/idl.dart';
21 import 'package:analyzer/src/summary/name_filter.dart'; 22 import 'package:analyzer/src/summary/name_filter.dart';
22 import 'package:analyzer/src/summary/summarize_const_expr.dart'; 23 import 'package:analyzer/src/summary/summarize_const_expr.dart';
23 import 'package:convert/convert.dart'; 24 import 'package:convert/convert.dart';
24 import 'package:crypto/crypto.dart'; 25 import 'package:crypto/crypto.dart';
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 if (accessor.isSynthetic && accessor.isGetter) { 444 if (accessor.isSynthetic && accessor.isGetter) {
444 PropertyInducingElement variable = accessor.variable; 445 PropertyInducingElement variable = accessor.variable;
445 if (variable != null) { 446 if (variable != null) {
446 assert(!variable.isSynthetic); 447 assert(!variable.isSynthetic);
447 variables.add(serializeVariable(variable)); 448 variables.add(serializeVariable(variable));
448 } 449 }
449 } 450 }
450 } 451 }
451 unlinkedUnit.variables = variables; 452 unlinkedUnit.variables = variables;
452 unlinkedUnit.references = unlinkedReferences; 453 unlinkedUnit.references = unlinkedReferences;
454 unlinkedUnit.lineStarts =
455 compilationUnit.context?.computeLineInfo(unitSource)?.lineStarts ??
Paul Berry 2016/08/08 18:38:10 Nit: the `?? const <int>[]` isn't necessary. The
456 const <int>[];
453 linkedUnit.references = linkedReferences; 457 linkedUnit.references = linkedReferences;
454 unitUri = compilationUnit.source.uri.toString(); 458 unitUri = compilationUnit.source.uri.toString();
455 } 459 }
456 460
457 /** 461 /**
458 * Create the [LinkedUnit.types] table based on deferred types that were 462 * Create the [LinkedUnit.types] table based on deferred types that were
459 * found during [addCompilationUnitElements]. Also populate 463 * found during [addCompilationUnitElements]. Also populate
460 * [LinkedUnit.constCycles]. 464 * [LinkedUnit.constCycles].
461 */ 465 */
462 void createLinkedInfo() { 466 void createLinkedInfo() {
(...skipping 1217 matching lines...) Expand 10 before | Expand all | Expand 10 after
1680 exportNames.add(new LinkedExportNameBuilder( 1684 exportNames.add(new LinkedExportNameBuilder(
1681 name: name, 1685 name: name,
1682 dependency: serializeDependency(dependentLibrary), 1686 dependency: serializeDependency(dependentLibrary),
1683 unit: unit, 1687 unit: unit,
1684 kind: kind)); 1688 kind: kind));
1685 } 1689 }
1686 pb.exportNames = exportNames; 1690 pb.exportNames = exportNames;
1687 return pb; 1691 return pb;
1688 } 1692 }
1689 } 1693 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | pkg/analyzer/test/src/summary/resynthesize_ast_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698