Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 2223093002: Merge to 2785 "[DevTools] Do not use "settings" query param." (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge to 2785 "[DevTools] Do not use "settings" query param." > [DevTools] Do not use "settings" query param. > > Implemented the same functionality on embedder side. > Also, sanitizing "settings" query param for remote frontends. > > BUG=618037 > > Review-Url: https://codereview.chromium.org/2177983004 > Cr-Commit-Position: refs/heads/master@{#407666} (cherry picked from commit d5e6098dc2e984befc836f482845137245fa04e2) TBR=pfeldman Committed: https://chromium.googlesource.com/chromium/src/+/956afd761251b3e5897165a5ea5434e84f0882fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -32 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 5 chunks +18 lines, -6 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgozman
4 years, 4 months ago (2016-08-08 17:18:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
956afd761251b3e5897165a5ea5434e84f0882fb.

Powered by Google App Engine
This is Rietveld 408576698