Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2177983004: [DevTools] Do not use "settings" query param. (Closed)

Created:
2 years, 10 months ago by dgozman
Modified:
2 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not use "settings" query param. Implemented the same functionality on embedder side. Also, sanitizing "settings" query param for remote frontends. BUG=618037 Committed: https://crrev.com/d5e6098dc2e984befc836f482845137245fa04e2 Cr-Commit-Position: refs/heads/master@{#407666}

Patch Set 1 #

Patch Set 2 : rework #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -32 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 5 chunks +18 lines, -6 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/devtools.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dgozman
Could you please take a look?
2 years, 10 months ago (2016-07-25 22:01:42 UTC) #4
pfeldman
lgtm
2 years, 10 months ago (2016-07-25 22:19:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2177983004/40001
2 years, 10 months ago (2016-07-26 00:42:54 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 10 months ago (2016-07-26 01:11:36 UTC) #11
commit-bot: I haz the power
2 years, 10 months ago (2016-07-26 01:16:11 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d5e6098dc2e984befc836f482845137245fa04e2
Cr-Commit-Position: refs/heads/master@{#407666}

Powered by Google App Engine
This is Rietveld 408576698