Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2222983002: [turbofan] Also consume number type feedback for abstract equality. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also consume number type feedback for abstract equality. This allows us to consume the type hints gathered by the CompareIC for the abstract equality and inequality operators. We need to distinguish Number and NumberOrOddball feedback now, as abstract equality doesn't truncate null and undefined to Number. R=epertoso@chromium.org BUG=v8:4583 Committed: https://crrev.com/b12a51c1f6b2c0d03c7896120c0e26c9a423f4b8 Cr-Commit-Position: refs/heads/master@{#38432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -56 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 4 chunks +44 lines, -29 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 6 chunks +28 lines, -4 lines 0 comments Download
M src/compiler/representation-change.h View 3 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +32 lines, -11 lines 0 comments Download
M src/compiler/simplified-operator.h View 3 chunks +13 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 7 chunks +51 lines, -1 line 0 comments Download
M src/compiler/type-hint-analyzer.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M src/compiler/type-hints.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/type-hints.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-08 10:48:23 UTC) #1
Benedikt Meurer
Hey Enrico, Utilizing the number feedback for == and != as well. Please take a ...
4 years, 4 months ago (2016-08-08 10:49:01 UTC) #4
epertoso
lgtm
4 years, 4 months ago (2016-08-08 10:54:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222983002/1
4 years, 4 months ago (2016-08-08 10:56:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 11:09:49 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 11:12:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b12a51c1f6b2c0d03c7896120c0e26c9a423f4b8
Cr-Commit-Position: refs/heads/master@{#38432}

Powered by Google App Engine
This is Rietveld 408576698