Move family of MakeError functions to C++

Move family of MakeError functions to C++

These were the final remnants of error code written in JavaScript.

BUG=

Committed: https://crrev.com/613e29b18df0b8230e66f3c6392e13541d111248
Cr-Commit-Position: refs/heads/master@{#38475}

[jgruber, 2016-08-08 07:22:41]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 07:22:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 07:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 07:37:22]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[jgruber, 2016-08-08 12:02:33]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 12:02:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-08 12:13:01]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 12:13:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 12:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 12:42:01]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-08 13:21:18]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-08-08 15:14:09]

lgtm

https://codereview.chromium.org/2222893002/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2222893002/diff/40001/src/bootstrapper.cc#new...
src/bootstrapper.cc:2491: Handle<JSObject> prototype =
I would keep it the old way. We would crash in debug mode instead of potentially
hiding a bug. Script objects should be accessible only devtools and v8, not by
user code.

[jgruber, 2016-08-09 06:59:16]

https://codereview.chromium.org/2222893002/diff/40001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2222893002/diff/40001/src/bootstrapper.cc#new...
src/bootstrapper.cc:2491: Handle<JSObject> prototype =
On 2016/08/08 15:14:09, Yang wrote:
> I would keep it the old way. We would crash in debug mode instead of
potentially
> hiding a bug. Script objects should be accessible only devtools and v8, not by
> user code.

I'm not completely sure what you mean. This should be equivalent to the old way,
which called SetCode(..., throw new Error(kUnsupported); ) in messages.js.

[Yang, 2016-08-09 07:31:14]

On 2016/08/09 06:59:16, jgruber wrote:
> https://codereview.chromium.org/2222893002/diff/40001/src/bootstrapper.cc
> File src/bootstrapper.cc (right):
> 
>
https://codereview.chromium.org/2222893002/diff/40001/src/bootstrapper.cc#new...
> src/bootstrapper.cc:2491: Handle<JSObject> prototype =
> On 2016/08/08 15:14:09, Yang wrote:
> > I would keep it the old way. We would crash in debug mode instead of
> potentially
> > hiding a bug. Script objects should be accessible only devtools and v8, not
by
> > user code.
> 
> I'm not completely sure what you mean. This should be equivalent to the old
way,
> which called SetCode(..., throw new Error(kUnsupported); ) in messages.js.

I overlooked that part. LGTM.

[jgruber, 2016-08-09 07:34:13]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-08-09 07:34:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 07:36:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-09 07:43:26]

Description was changed from

==========
Move family of MakeError functions to C++

These were the final remnants of error code written in JavaScript.

BUG=
==========

to

==========
Move family of MakeError functions to C++

These were the final remnants of error code written in JavaScript.

BUG=

Committed: https://crrev.com/613e29b18df0b8230e66f3c6392e13541d111248
Cr-Commit-Position: refs/heads/master@{#38475}
==========

[commit-bot: I haz the power, 2016-08-09 07:43:27]

Patchset 3 (id:??) landed as
https://crrev.com/613e29b18df0b8230e66f3c6392e13541d111248
Cr-Commit-Position: refs/heads/master@{#38475}