Move remaining Message functions to C++

Move remaining Message functions to C++

BUG=

Committed: https://crrev.com/a91811e192bc0c973bbcba5f569e31e95f254777
Cr-Commit-Position: refs/heads/master@{#38529}

[jgruber, 2016-08-08 13:23:29]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 13:23:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-08 13:24:32]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 13:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-08 14:00:17]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-08-08 14:00:18]

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc#newcode2457
src/api.cc:2457: return Just(msg->GetLineNumber());
Here and all other cases below: even though this is a Maybe<> function, an error
is still passed as Just(some constant) instead of Nothing. That feels wrong, but
I'm not sure about changing the behavior of some API function.

Only one of our tests fails on this, haven't checked layout tests yet.

Opinions?

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc#newcode2503
src/api.cc:2503: if (column_number == -1) return Just(-1);
This is a behavior change. Previously any error was obfuscated by adding
end-start below.

[commit-bot: I haz the power, 2016-08-08 14:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:03:45]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-08 14:04:06]

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc#newcode2457
src/api.cc:2457: return Just(msg->GetLineNumber());
On 2016/08/08 14:00:18, jgruber wrote:
> Here and all other cases below: even though this is a Maybe<> function, an
error
> is still passed as Just(some constant) instead of Nothing. That feels wrong,
but
> I'm not sure about changing the behavior of some API function.
> 
> Only one of our tests fails on this, haven't checked layout tests yet.
> 
> Opinions? 

The failing test is test-api/PromiseRejectCallback by the way.

[Yang, 2016-08-10 09:03:18]

Nice. LGTM.

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2224973002/diff/20001/src/api.cc#newcode2457
src/api.cc:2457: return Just(msg->GetLineNumber());
On 2016/08/08 14:04:06, jgruber wrote:
> On 2016/08/08 14:00:18, jgruber wrote:
> > Here and all other cases below: even though this is a Maybe<> function, an
> error
> > is still passed as Just(some constant) instead of Nothing. That feels wrong,
> but
> > I'm not sure about changing the behavior of some API function.
> > 
> > Only one of our tests fails on this, haven't checked layout tests yet.
> > 
> > Opinions? 
> 
> The failing test is test-api/PromiseRejectCallback by the way.

As discussed, let's leave the API.

https://codereview.chromium.org/2224973002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2224973002/diff/20001/src/objects.cc#newcode1...
src/objects.cc:18926: return info.column;  // Note: No + 1.
please rephrase the comment as "No '+1'". Otherwise it might look like an
abbreviation for "Number + 1"

[jgruber, 2016-08-10 09:18:35]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 09:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 09:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 09:19:50]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/10720)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10661)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21494)

[jgruber, 2016-08-10 09:24:36]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 09:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-10 09:25:10]

https://codereview.chromium.org/2224973002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2224973002/diff/20001/src/objects.cc#newcode1...
src/objects.cc:18926: return info.column;  // Note: No + 1.
On 2016/08/10 09:03:18, Yang wrote:
> please rephrase the comment as "No '+1'". Otherwise it might look like an
> abbreviation for "Number + 1"

Done.

[commit-bot: I haz the power, 2016-08-10 09:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 09:48:55]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-10 09:56:35]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-08-10 09:56:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2224973002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-10 09:56:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 09:58:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-10 09:58:34]

Description was changed from

==========
Move remaining Message functions to C++

BUG=
==========

to

==========
Move remaining Message functions to C++

BUG=

Committed: https://crrev.com/a91811e192bc0c973bbcba5f569e31e95f254777
Cr-Commit-Position: refs/heads/master@{#38529}
==========

[commit-bot: I haz the power, 2016-08-10 09:58:36]

Patchset 4 (id:??) landed as
https://crrev.com/a91811e192bc0c973bbcba5f569e31e95f254777
Cr-Commit-Position: refs/heads/master@{#38529}