Properly name the timeout callback for update event.

Properly name the timeout callback for update event.

Making timer callback public for testing as per Marijn's comment in https://codereview.chromium.org/2192413002/.

BUG=629462
Committed: https://crrev.com/16ba70a3e0d4996af6c60412092762447ae69020
Cr-Commit-Position: refs/heads/master@{#421135}

[pals, 2016-08-08 06:36:37]

The CQ bit was checked by sanjoy.pal@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 08:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 08:05:56]

Dry run: This issue passed the CQ dry run.

[pals, 2016-09-15 07:27:09]

sanjoy.pal@samsung.com changed reviewers:
+ rouslan@chromium.org

[pals, 2016-09-15 07:27:10]

PTAL.

[please use gerrit instead, 2016-09-15 15:23:54]

LGTM here, but I'm on the fence about usefulness of these kinds of patches. Can
we discuss patches on http://crbug.com before writing them up next time?

[pals, 2016-09-16 05:21:59]

On 2016/09/15 15:23:54, rouslan wrote:
> LGTM here, but I'm on the fence about usefulness of these kinds of patches.
Can
> we discuss patches on http://crbug.com before writing them up next time?

I created this patch a month back while reviewing one of your patch
https://codereview.chromium.org/2192413002/ where Marijin suggested to make
timerFired callback private. So, i thought of make this part of code similar to
that. I should have discussed before writing this patch. Shall I discard this
change?

[please use gerrit instead, 2016-09-16 15:42:47]

You may commit this patch, but please provide a better description for patches
like this. The description should mention the previous discussions with Marijn
and (optimally) also link to the pre-existing conversations.

[pals, 2016-09-27 04:33:55]

Description was changed from

==========
Properly name the timeout callback for update event.

BUG=629462
==========

to

==========
Properly name the timeout callback for update event.

Making timer callback public for testing as per Marijn's comment in
https://codereview.chromium.org/2192413002/.

BUG=629462
==========

[pals, 2016-09-27 04:34:01]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2016-09-27 04:34:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 07:16:46]

Description was changed from

==========
Properly name the timeout callback for update event.

Making timer callback public for testing as per Marijn's comment in
https://codereview.chromium.org/2192413002/.

BUG=629462
==========

to

==========
Properly name the timeout callback for update event.

Making timer callback public for testing as per Marijn's comment in
https://codereview.chromium.org/2192413002/.

BUG=629462
==========

[commit-bot: I haz the power, 2016-09-27 07:16:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-27 07:18:32]

Description was changed from

==========
Properly name the timeout callback for update event.

Making timer callback public for testing as per Marijn's comment in
https://codereview.chromium.org/2192413002/.

BUG=629462
==========

to

==========
Properly name the timeout callback for update event.

Making timer callback public for testing as per Marijn's comment in
https://codereview.chromium.org/2192413002/.

BUG=629462

Committed: https://crrev.com/16ba70a3e0d4996af6c60412092762447ae69020
Cr-Commit-Position: refs/heads/master@{#421135}
==========

[commit-bot: I haz the power, 2016-09-27 07:18:33]

Patchset 1 (id:??) landed as
https://crrev.com/16ba70a3e0d4996af6c60412092762447ae69020
Cr-Commit-Position: refs/heads/master@{#421135}