third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp - Issue 2222883002: Properly name the timeout callback for update event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

Issue 2222883002: Properly name the timeout callback for update event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

index fdaa7f8ee3f7586bb88aa4d3a32e32be1d93f46c..ca8915520cd2711324b13be0e156f3086f509931 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

@@ -116,7 +116,7 @@ TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsTimeout)

String errorMessage;

request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall(&errorMessage));

- event->onTimerFired(0);

+ event->onUpdateEventTimeoutForTesting();

v8::MicrotasksScope::PerformCheckpoint(scope.getScriptState()->isolate());

EXPECT_EQ("AbortError: Timed out as the page didn't resolve the promise from change event", errorMessage);

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp ('k') | no next file » | no next file with comments »