Issue 2222843006: Skip certificate whitelist checking if download URL already matches whitelist and gets sampled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2222843006: Skip certificate whitelist checking if download URL already matches whitelist and gets sampled. (Closed)

Created:
4 years, 4 months ago by Jialiu Lin

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Skip certificate whitelist checking if download URL already matches whitelist and gets sampled. This will speed up the whitelisting checking process for some downloads, and would potentially slightly increase the number of whitelisted ping we get. BUG=631550 Review-Url: https://codereview.chromium.org/2201213007 Cr-Commit-Position: refs/heads/master@{#410133} (cherry picked from commit 389ba5efb8a7659573f1c72095c4eb23275612ed) Committed: https://chromium.googlesource.com/chromium/src/+/2df48ee378d55469881502aff2690fd743d06d25

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -18 lines)			Patch
	M	chrome/browser/safe_browsing/download_protection_service.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View		6 chunks	+79 lines, -15 lines	0 comments	Download

Total messages: 2 (1 generated)

Jialiu Lin

4 years, 4 months ago (2016-08-08 19:17:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2df48ee378d55469881502aff2690fd743d06d25 (tree was closed).