Skip cert whitelist checking if download URL matches whitelist and sampled

Skip certificate whitelist checking if download URL already matches whitelist and
gets sampled.

This will speed up the whitelisting checking process for some downloads, and would
potentially slightly increase the number of whitelisted ping we get.

BUG=631550
Committed: https://crrev.com/389ba5efb8a7659573f1c72095c4eb23275612ed
Cr-Commit-Position: refs/heads/master@{#410133}

[Jialiu Lin, 2016-08-04 17:33:38]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 17:34:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-08-04 18:15:42]

Patchset #2 (id:20001) has been deleted

[Jialiu Lin, 2016-08-04 18:16:39]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2016-08-04 18:16:40]

Hi nparker@, 
I made a small change to the current whitelist sampling code. Basically if a
download has already matched URL whitelist and got sampled, don't proceed to
check certificate whitelist anymore.
This change may slightly increase the number of whitelisted ping SB gets.

https://codereview.chromium.org/2201213007/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

https://codereview.chromium.org/2201213007/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:860: 
test case (1) - (4) are the same (just reordered).
added test cases (5) and (6)

[Jialiu Lin, 2016-08-05 17:25:46]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:26:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nathan Parker, 2016-08-05 17:27:10]

lgtm

https://codereview.chromium.org/2201213007/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

https://codereview.chromium.org/2201213007/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:882:
MatchDownloadWhitelistUrl(GURL("http://www.whitelist.com/a.exe")))
nit: > 80 char line?  Below as well.

[Jialiu Lin, 2016-08-05 17:32:25]

Thanks!

https://codereview.chromium.org/2201213007/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/download_protection_service_unittest.cc
(right):

https://codereview.chromium.org/2201213007/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/download_protection_service_unittest.cc:882:
MatchDownloadWhitelistUrl(GURL("http://www.whitelist.com/a.exe")))
On 2016/08/05 at 17:27:10, Nathan Parker wrote:
> nit: > 80 char line?  Below as well.

Oops, fixed.

[Jialiu Lin, 2016-08-05 18:30:23]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2016-08-05 18:30:24]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/2201213007/#ps60001
(title: "line > 80")

[commit-bot: I haz the power, 2016-08-05 18:30:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 19:15:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-05 19:16:33]

Description was changed from

==========
Skip certificate whitelist checking if download URL already matches whitelist
and
gets sampled.

This will speed up the whitelisting checking process for some downloads, and
would
potentially slightly increase the number of whitelisted ping we get.

BUG=631550
==========

to

==========
Skip certificate whitelist checking if download URL already matches whitelist
and
gets sampled.

This will speed up the whitelisting checking process for some downloads, and
would
potentially slightly increase the number of whitelisted ping we get.

BUG=631550

Committed: https://crrev.com/389ba5efb8a7659573f1c72095c4eb23275612ed
Cr-Commit-Position: refs/heads/master@{#410133}
==========

[commit-bot: I haz the power, 2016-08-05 19:16:34]

Patchset 3 (id:??) landed as
https://crrev.com/389ba5efb8a7659573f1c72095c4eb23275612ed
Cr-Commit-Position: refs/heads/master@{#410133}