Remove unnecessary checks for forced context allocation

Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org

Committed: https://crrev.com/86e141eb2ddf89b98f8629c73e94440f83651f7f
Cr-Commit-Position: refs/heads/master@{#38504}

[adamk, 2016-08-08 18:28:47]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 18:28:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 19:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:07:17]

Dry run: This issue passed the CQ dry run.

[neis, 2016-08-09 07:15:26]

lgtm, thanks!

https://codereview.chromium.org/2222843005/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2222843005/diff/1/src/ast/scopes.cc#newcode1581
src/ast/scopes.cc:1581: // Force context allocation of the parameter.
Maybe remove the comment too as it doesn't add any information.

[neis, 2016-08-09 09:59:39]

Description was changed from

==========
Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org
==========

to

==========
Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org
==========

[adamk, 2016-08-09 16:29:01]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-08-09 16:29:02]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2222843005/#ps20001
(title: "Removed comment")

[adamk, 2016-08-09 16:29:11]

https://codereview.chromium.org/2222843005/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2222843005/diff/1/src/ast/scopes.cc#newcode1581
src/ast/scopes.cc:1581: // Force context allocation of the parameter.
On 2016/08/09 07:15:26, neis wrote:
> Maybe remove the comment too as it doesn't add any information.

Done.

[commit-bot: I haz the power, 2016-08-09 16:29:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 17:03:51]

Description was changed from

==========
Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org
==========

to

==========
Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org
==========

[commit-bot: I haz the power, 2016-08-09 17:03:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 17:04:09]

Description was changed from

==========
Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org
==========

to

==========
Remove unnecessary checks for forced context allocation

If a whole scope has forced context allocation, MustAllocateInContext()
already takes care of returning true for all variables, there's no need
to individually call ForceContextAllocation() on them.

R=neis@chromium.org

Committed: https://crrev.com/86e141eb2ddf89b98f8629c73e94440f83651f7f
Cr-Commit-Position: refs/heads/master@{#38504}
==========

[commit-bot: I haz the power, 2016-08-09 17:04:09]

Patchset 2 (id:??) landed as
https://crrev.com/86e141eb2ddf89b98f8629c73e94440f83651f7f
Cr-Commit-Position: refs/heads/master@{#38504}