Remove unnecessary checks for forced context allocation

src/ast/scopes.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/scopes.h"
 
 #include <set>
 
 #include "src/accessors.h"
 #include "src/bootstrapper.h"
@@ skipping 1559 matching lines @@
 
   // The same parameter may occur multiple times in the parameters_ list.
   // If it does, and if it is not copied into the context object, it must
   // receive the highest parameter index for that parameter; thus iteration
   // order is relevant!
   for (int i = params_.length() - 1; i >= 0; --i) {
     Variable* var = params_[i];
     if (var == rest_parameter_) continue;
 
     DCHECK(var->scope() == this);
-    if (uses_sloppy_arguments || has_forced_context_allocation()) {
+    if (uses_sloppy_arguments) {
       // Force context allocation of the parameter.

[neis, 2016/08/09 07:15:26]

Maybe remove the comment too as it doesn't add any information.

[adamk, 2016/08/09 16:29:11]

Done.

       var->ForceContextAllocation();
     }
     AllocateParameter(var, i);
   }
 }
 
 void DeclarationScope::AllocateParameter(Variable* var, int index) {
   if (MustAllocate(var)) {
     if (MustAllocateInContext(var)) {
       DCHECK(var->IsUnallocated() || var->IsContextSlot());
       if (var->IsUnallocated()) {
         AllocateHeapSlot(var);
       }
     } else {
       DCHECK(var->IsUnallocated() || var->IsParameter());
       if (var->IsUnallocated()) {
         var->AllocateTo(VariableLocation::PARAMETER, index);
       }
     }
   } else {
     DCHECK(!var->IsGlobalSlot());
   }
 }
 
 void DeclarationScope::AllocateReceiver() {
   if (!has_this_declaration()) return;
   DCHECK_NOT_NULL(receiver());
   DCHECK_EQ(receiver()->scope(), this);
-
-  if (has_forced_context_allocation()) {
-    // Force context allocation of the receiver.
-    receiver()->ForceContextAllocation();
-  }
   AllocateParameter(receiver(), -1);
 }
 
 void Scope::AllocateNonParameterLocal(Variable* var,
                                       AstValueFactory* ast_value_factory) {
   DCHECK(var->scope() == this);
   DCHECK(var->raw_name() != ast_value_factory->dot_result_string() ||
          !var->IsStackLocal());
   if (var->IsUnallocated() && MustAllocate(var)) {
     if (MustAllocateInContext(var)) {
@@ skipping 157 matching lines @@
       function != NULL && function->proxy()->var()->IsContextSlot();
   return num_heap_slots() - Context::MIN_CONTEXT_SLOTS - num_global_slots() -
          (is_function_var_in_context ? 1 : 0);
 }
 
 
 int Scope::ContextGlobalCount() const { return num_global_slots(); }
 
 }  // namespace internal
 }  // namespace v8