extensions/browser/bad_message.h - Issue 2222723002: Avoid calling into the ContentBrowserClient interface from ResourceDispatcherHostImpl to determine …

Unified Diff: extensions/browser/bad_message.h

Issue 2222723002: Avoid calling into the ContentBrowserClient interface from ResourceDispatcherHostImpl to determine … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compile failures Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/bad_message.h

diff --git a/extensions/browser/bad_message.h b/extensions/browser/bad_message.h

index bef0c712b388f95f45cf4666a2301b08b1dde0fc..61588f493ca1161c89f67f991a6002bcad87ffcb 100644

--- a/extensions/browser/bad_message.h

+++ b/extensions/browser/bad_message.h

@@ -28,6 +28,7 @@ enum BadMessageReason {

AVG_BAD_INST_ID = 4,

AVG_BAD_EXT_ID = 5,

AVG_NULL_AVG = 6,

+ INVALID_ORIGIN = 7,

jam 2016/08/09 01:36:24 I'm curious what is the reason to start instrument

ananta 2016/08/09 05:47:48 Reason being, to pass in a bad message code to con

jam 2016/08/10 00:19:26 I'm not sure I follow. The bad_message::Received

ananta 2016/08/10 00:30:02 We cannot assume RDH_ILLEGAL_ORIGIN all the time.

// Please add new elements here. The naming convention is abbreviated class

// name (e.g. ExtensionHost becomes EH) plus a unique description of the

// reason. After making changes, you MUST update histograms.xml by running:

« content/public/browser/resource_dispatcher_host_interceptor.h ('K') | « content/public/browser/resource_dispatcher_host_interceptor.cc ('k') | no next file » | no next file with comments »