Avoid calling into the ContentBrowserClient interface from ResourceDispatcherHostImpl to determine …

extensions/browser/bad_message.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_
 #define EXTENSIONS_BROWSER_BAD_MESSAGE_H_
 
 namespace content {
 class RenderProcessHost;
 }
@@ skipping 10 matching lines @@
 // end. Items may be renamed but do not change the values. We rely on the enum
 // values in histograms.
 enum BadMessageReason {
   EOG_BAD_ORIGIN = 0,
   EVG_BAD_ORIGIN = 1,
   BH_BLOB_NOT_OWNED = 2,
   EH_BAD_EVENT_ID = 3,
   AVG_BAD_INST_ID = 4,
   AVG_BAD_EXT_ID = 5,
   AVG_NULL_AVG = 6,
+  INVALID_ORIGIN = 7,

[jam, 2016/08/09 01:36:24]

I'm curious what is the reason to start instrumenting this?

[ananta, 2016/08/09 05:47:48]

Reason being, to pass in a bad message code to content. The bad_message.h
currently being used is not accessible outside content. Till now it wasn't an
issue because we were returning true/false from IsIllegalOrigin from the
embedder.

[jam, 2016/08/10 00:19:26]

I'm not sure I follow.

The  bad_message::ReceivedBadMessage call is in content
(ResourceDispatcherHostImpl::ContinuePendingBeginRequest), so why can't it just
always call bad_message::ReceivedBadMessage(bad_message::RDH_ILLEGAL_ORIGIN)
?

[ananta, 2016/08/10 00:30:02]

We cannot assume RDH_ILLEGAL_ORIGIN all the time. The current use case, yes.
However not if we consider other header inspectors going forward.

   // Please add new elements here. The naming convention is abbreviated class
   // name (e.g. ExtensionHost becomes EH) plus a unique description of the
   // reason. After making changes, you MUST update histograms.xml by running:
   // "python tools/metrics/histograms/update_bad_message_reasons.py"
   BAD_MESSAGE_MAX
 };
 
 // Called when the browser receives a bad IPC message from an extension process.
 // Logs the event, records a histogram metric for the |reason|, and terminates
 // the process for |host|.
 void ReceivedBadMessage(content::RenderProcessHost* host,
                         BadMessageReason reason);
 
 }  // namespace bad_message
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_BAD_MESSAGE_H_