Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2222713004: [devtools] _parseMap in SourceMap.js does not strictly follow specs (Closed)

Created:
4 years, 4 months ago by darwin
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[devtools] _parseMap in SourceMap.js does not strictly follow specs Also add tests for issue 611738 BUG=611738 Committed: https://crrev.com/51f1de9d9288bc3603f38d30341cc61e960bd44d Cr-Commit-Position: refs/heads/master@{#415074}

Patch Set 1 #

Total comments: 2

Patch Set 2 : [devtools] _parseMap in SourceMap.js does not strictly follow specs #

Total comments: 1

Patch Set 3 : [devtools] _parseMap in SourceMap.js does not strictly follow specs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
darwin
My first submission ever. Please forgive mistakes. Random bits of experience of a first-time committer: ...
4 years, 4 months ago (2016-08-06 22:02:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222713004/1
4 years, 4 months ago (2016-08-15 22:48:01 UTC) #5
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 4 months ago (2016-08-15 22:48:02 UTC) #7
lushnikov
Thank you! You also want to add yourself in the src/AUTHORS file https://codereview.chromium.org/2222713004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html File third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html ...
4 years, 3 months ago (2016-08-25 19:48:37 UTC) #9
darwin
An attempt to update the patch.
4 years, 3 months ago (2016-08-26 23:13:09 UTC) #10
lushnikov
https://codereview.chromium.org/2222713004/diff/20001/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2222713004/diff/20001/AUTHORS#newcode733 AUTHORS:733: Antonin Hildebrand <antonin.hildebrand@gmail.com> let's put your name in alphabetic ...
4 years, 3 months ago (2016-08-26 23:16:15 UTC) #11
darwin
Getting better at updating patches :)
4 years, 3 months ago (2016-08-26 23:26:25 UTC) #12
lushnikov
great, thank you! lgtm
4 years, 3 months ago (2016-08-26 23:33:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222713004/40001
4 years, 3 months ago (2016-08-26 23:34:08 UTC) #15
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from ...
4 years, 3 months ago (2016-08-26 23:34:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222713004/40001
4 years, 3 months ago (2016-08-30 00:17:23 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 04:07:56 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:09:33 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51f1de9d9288bc3603f38d30341cc61e960bd44d
Cr-Commit-Position: refs/heads/master@{#415074}

Powered by Google App Engine
This is Rietveld 408576698