Chromium Code Reviews Chromium Code Reviews
Issue 2222713004:
[devtools] _parseMap in SourceMap.js does not strictly follow specs (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <script src="inspector-test.js"></script> | 3 <script src="inspector-test.js"></script> |
| 4 <script src="debugger-test.js"></script> | 4 <script src="debugger-test.js"></script> |
| 5 <script src="workspace-test.js"></script> | 5 <script src="workspace-test.js"></script> |
| 6 <script src="breakpoint-manager-test.js"></script> | 6 <script src="breakpoint-manager-test.js"></script> |
| 7 | 7 |
| 8 <script> | 8 <script> |
| 9 | 9 |
| 10 function test() | 10 function test() |
| (...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 468 { | 468 { |
| 469 var mappingPayload = { | 469 var mappingPayload = { |
| 470 "mappings":"AAASA,QAAAA,IAAG,CAACC,CAAD,CAAaC,CAAb,CACZ,CACI,MAA OD,EAAP,CAAoBC,CADxB,CAIA,IAAIC,OAAS;", | 470 "mappings":"AAASA,QAAAA,IAAG,CAACC,CAAD,CAAaC,CAAb,CACZ,CACI,MAA OD,EAAP,CAAoBC,CADxB,CAIA,IAAIC,OAAS;", |
| 471 "sources":["example.js"], | 471 "sources":["example.js"], |
| 472 "sourcesContent":["var i = 0;"] | 472 "sourcesContent":["var i = 0;"] |
| 473 }; | 473 }; |
| 474 var mapping = new WebInspector.TextSourceMap("example.js", "source-m ap.json",mappingPayload); | 474 var mapping = new WebInspector.TextSourceMap("example.js", "source-m ap.json",mappingPayload); |
| 475 checkMapping(0, 9, "example.js", 0, 9, mapping); | 475 checkMapping(0, 9, "example.js", 0, 9, mapping); |
| 476 checkReverseMapping(0, 0, "example.js", 0, mapping); | 476 checkReverseMapping(0, 0, "example.js", 0, mapping); |
| 477 next(); | 477 next(); |
| 478 }, | |
| 479 | |
| 480 function testIssue611738(next) | |
|
lushnikov
2016/08/25 19:48:36
let's name this testNameIndexes
| |
| 481 { | |
| 482 /* | |
| 483 ----------------------------------------------------------------- ------------------- | |
| 484 chrome_issue_611738.cljs: | |
| 485 (ns devtools-sample.chrome-issue-611738 | |
| 486 (:require-macros [devtools-sample.chrome-issue-611738 :refer [m]] )) | |
| 487 | |
| 488 (let [name1 "value1"] | |
| 489 (m)) | |
| 490 ----------------------------------------------------------------- ------------------- | |
| 491 chrome_issue_611738.js: | |
| 492 // Compiled by ClojureScript 1.9.89 {} | |
| 493 goog.provide('devtools_sample.chrome_issue_611738'); | |
| 494 goog.require('cljs.core'); | |
| 495 var name1_31466 = "value1"; | |
| 496 var generated31465_31467 = "value2"; | |
| 497 | |
| 498 //# sourceMappingURL=chrome_issue_611738.js.map | |
| 499 ----------------------------------------------------------------- ------------------- | |
| 500 chrome_issue_611738.js.map: | |
| 501 {"version":3,"file":"\/Users\/darwin\/code\/cljs-devtools-sample\ /resources\/public\/_compiled\/demo\/devtools_sample\/chrome_issue_611738.js","s ources":["chrome_issue_611738.cljs"],"lineCount":7,"mappings":";AAAA;;AAGA,kBAAA ,dAAMA;AAAN,AACE,IAAAC,uBAAA;AAAA,AAAA","names":["name1","generated31465"]} | |
| 502 ----------------------------------------------------------------- ------------------- | |
| 503 Related links: | |
|
lushnikov
2016/08/25 19:48:36
let's remove the "related links"
| |
| 504 https://gist.github.com/darwin/4103df378bc21ed0af41897e2f5b1762 | |
| 505 https://sokra.github.io/source-map-visualization/#base64,Ly8gQ29t cGlsZWQgYnkgQ2xvanVyZVNjcmlwdCAxLjkuODkge30KZ29vZy5wcm92aWRlKCdkZXZ0b29sc19zYW1w bGUuY2hyb21lX2lzc3VlXzYxMTczOCcpOwpnb29nLnJlcXVpcmUoJ2NsanMuY29yZScpOwp2YXIgbmFt ZTFfMzE0NjYgPSAidmFsdWUxIjsKdmFyIGdlbmVyYXRlZDMxNDY1XzMxNDY3ID0gInZhbHVlMiI7Cgov LyMgc291cmNlTWFwcGluZ1VSTD1jaHJvbWVfaXNzdWVfNjExNzM4LmpzLm1hcAo=,eyJ2ZXJzaW9uIjo zLCJmaWxlIjoiL1VzZXJzL2Rhcndpbi9jb2RlL2NsanMtZGV2dG9vbHMtc2FtcGxlL3Jlc291cmNlcy9 wdWJsaWMvX2NvbXBpbGVkL2RlbW8vZGV2dG9vbHNfc2FtcGxlL2Nocm9tZV9pc3N1ZV82MTE3MzguanM iLCJzb3VyY2VzIjpbImNocm9tZV9pc3N1ZV82MTE3MzguY2xqcyJdLCJsaW5lQ291bnQiOjcsIm1hcHB pbmdzIjoiO0FBQUE7O0FBR0Esa0JBQUEsZEFBTUE7QUFBTixBQUNFLElBQUFDLHVCQUFBO0FBQUEsQUF BQSIsIm5hbWVzIjpbIm5hbWUxIiwiZ2VuZXJhdGVkMzE0NjUiXX0=,KG5zIGRldnRvb2xzLXNhbXBsZS 5jaHJvbWUtaXNzdWUtNjExNzM4CiAgKDpyZXF1aXJlLW1hY3JvcyBbZGV2dG9vbHMtc2FtcGxlLmNocm 9tZS1pc3N1ZS02MTE3MzggOnJlZmVyIFttXV0pKQoKKGxldCBbbmFtZTEgInZhbHVlMSJdCiAgKG0pKQ oK | |
| 506 */ | |
| 507 | |
| 508 var mappingPayload = { | |
| 509 "sources": ["chrome_issue_611738.cljs"], | |
| 510 "mappings": ";AAAA;;AAGA,kBAAA,dAAMA;AAAN,AACE,IAAAC,uBAAA;AAAA, AAAA", | |
| 511 "names": ["name1", "generated31465"] | |
| 512 }; | |
| 513 var mapping = new WebInspector.TextSourceMap("chrome_issue_611738.js ", "chrome_issue_611738.js.map", mappingPayload); | |
| 514 mapping.mappings().forEach(function(entry) { | |
| 515 const name = entry.name ? "'" + entry.name + "'" : "[no name ass igned]"; | |
| 516 InspectorTest.addResult(entry.lineNumber + ":" + entry.columnNum ber + " > " + name); | |
| 517 }); | |
| 518 next(); | |
| 478 } | 519 } |
| 479 ]); | 520 ]); |
| 480 }; | 521 }; |
| 481 | 522 |
| 482 </script> | 523 </script> |
| 483 | 524 |
| 484 </head> | 525 </head> |
| 485 | 526 |
| 486 <body onload="runTest()"> | 527 <body onload="runTest()"> |
| 487 <p>Tests SourceMap and CompilerScriptMapping.</p> | 528 <p>Tests SourceMap and CompilerScriptMapping.</p> |
| 488 </body> | 529 </body> |
| 489 </html> | 530 </html> |
| OLD | NEW |
