Dismiss tooltip on all scrolls, not just frame scrolls.

Dismiss tooltip on all scrolls, not just frame scrolls.

This will cover the case of frame-level scrolls with root layer
scrolling turned on.

Also, parameterize FrameViewTest for root layer scrolls.

BUG=586852, 490942
R=skobes@chromium.org,tdresser@chromium.org

Committed: https://crrev.com/330d5a2e498f8df18da9a4f5547b2663f817df7a
Cr-Commit-Position: refs/heads/master@{#410257}

[skobes, 2016-08-05 23:13:12]

lgtm

[szager1, 2016-08-05 23:13:47]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:14:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 02:55:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-06 02:57:21]

Description was changed from

==========
Dismiss tooltip on all scrolls, not just frame scrolls.

This will cover the case of frame-level scrolls with root layer
scrolling turned on.

Also, parameterize FrameViewTest for root layer scrolls.

BUG=586852,490942
R=skobes@chromium.org,tdresser@chromium.org
==========

to

==========
Dismiss tooltip on all scrolls, not just frame scrolls.

This will cover the case of frame-level scrolls with root layer
scrolling turned on.

Also, parameterize FrameViewTest for root layer scrolls.

BUG=586852,490942
R=skobes@chromium.org,tdresser@chromium.org

Committed: https://crrev.com/330d5a2e498f8df18da9a4f5547b2663f817df7a
Cr-Commit-Position: refs/heads/master@{#410257}
==========

[commit-bot: I haz the power, 2016-08-06 02:57:22]

Patchset 1 (id:??) landed as
https://crrev.com/330d5a2e498f8df18da9a4f5547b2663f817df7a
Cr-Commit-Position: refs/heads/master@{#410257}

[tdresser, 2016-08-08 13:15:44]

https://codereview.chromium.org/2222693002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameViewTest.cpp (right):

https://codereview.chromium.org/2222693002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameViewTest.cpp:113:
&RootLayerScrollsFrameSettingOverride));
Aren't these two instantiations identical?

[szager1, 2016-08-08 18:12:35]

https://codereview.chromium.org/2222693002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameViewTest.cpp (right):

https://codereview.chromium.org/2222693002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameViewTest.cpp:113:
&RootLayerScrollsFrameSettingOverride));
On 2016/08/08 13:15:44, tdresser wrote:
> Aren't these two instantiations identical?

No, the first one ("nullptr") will not apply any overrides.

[tdresser, 2016-08-08 18:21:29]

LGTM.

https://codereview.chromium.org/2222693002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameViewTest.cpp (right):

https://codereview.chromium.org/2222693002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameViewTest.cpp:113:
&RootLayerScrollsFrameSettingOverride));
On 2016/08/08 18:12:34, szager1 wrote:
> On 2016/08/08 13:15:44, tdresser wrote:
> > Aren't these two instantiations identical?
> 
> No, the first one ("nullptr") will not apply any overrides.

Whoops, sorry, I was forgetting how INSTANTIATE_TEST_CASE_P works.