Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2222693002: Dismiss tooltip on all scrolls, not just frame scrolls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@rls-enable
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 368
369 const LayoutBoxModelObject& paintInvalidationContainer = box().containerForP aintInvalidation(); 369 const LayoutBoxModelObject& paintInvalidationContainer = box().containerForP aintInvalidation();
370 // The caret rect needs to be invalidated after scrolling 370 // The caret rect needs to be invalidated after scrolling
371 frame->selection().setCaretRectNeedsUpdate(); 371 frame->selection().setCaretRectNeedsUpdate();
372 372
373 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(layer()->layoutObj ect()->previousPaintInvalidationRectIncludingCompositedScrolling(paintInvalidati onContainer))); 373 FloatQuad quadForFakeMouseMoveEvent = FloatQuad(FloatRect(layer()->layoutObj ect()->previousPaintInvalidationRectIncludingCompositedScrolling(paintInvalidati onContainer)));
374 374
375 quadForFakeMouseMoveEvent = paintInvalidationContainer.localToAbsoluteQuad(q uadForFakeMouseMoveEvent); 375 quadForFakeMouseMoveEvent = paintInvalidationContainer.localToAbsoluteQuad(q uadForFakeMouseMoveEvent);
376 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 376 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
377 377
378 Page* page = frame->page();
379 if (page)
380 page->chromeClient().clearToolTip();
381
378 bool requiresPaintInvalidation = true; 382 bool requiresPaintInvalidation = true;
379 383
380 if (box().view()->compositor()->inCompositingMode()) { 384 if (box().view()->compositor()->inCompositingMode()) {
381 bool onlyScrolledCompositedLayers = scrollsOverflow() 385 bool onlyScrolledCompositedLayers = scrollsOverflow()
382 && layer()->isAllScrollingContentComposited() 386 && layer()->isAllScrollingContentComposited()
383 && box().style()->backgroundLayers().attachment() != LocalBackground Attachment; 387 && box().style()->backgroundLayers().attachment() != LocalBackground Attachment;
384 388
385 if (usesCompositedScrolling() || onlyScrolledCompositedLayers) 389 if (usesCompositedScrolling() || onlyScrolledCompositedLayers)
386 requiresPaintInvalidation = false; 390 requiresPaintInvalidation = false;
387 } 391 }
(...skipping 1370 matching lines...) Expand 10 before | Expand all | Expand 10 after
1758 1762
1759 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as() 1763 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as()
1760 { 1764 {
1761 for (auto& scrollableArea : *s_needsClamp) 1765 for (auto& scrollableArea : *s_needsClamp)
1762 scrollableArea->clampScrollPositionsAfterLayout(); 1766 scrollableArea->clampScrollPositionsAfterLayout();
1763 delete s_needsClamp; 1767 delete s_needsClamp;
1764 s_needsClamp = nullptr; 1768 s_needsClamp = nullptr;
1765 } 1769 }
1766 1770
1767 } // namespace blink 1771 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698