Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2222533003: [Android] Pass known devices file path to host info to detect missing devices. (Closed)

Created:
4 years, 4 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Pass known devices file path to host info to detect missing devices. BUG=592140 Committed: https://chromium.googlesource.com/chromium/tools/build/+/47e92bc8f5032a745175810c0f7096e4b3d7d3b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/host_info_failure.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rnephew (Reviews Here)
Requires https://codereview.chromium.org/2214883002/ to actually do anything, but not to land. It will be a nop ...
4 years, 4 months ago (2016-08-05 16:11:38 UTC) #2
jbudorick
lgtm
4 years, 4 months ago (2016-08-05 16:26:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222533003/1
4 years, 4 months ago (2016-08-05 16:28:04 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 16:34:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/47e92bc8f5032a745175...

Powered by Google App Engine
This is Rietveld 408576698