scripts/slave/recipe_modules/chromium_android/api.py - Issue 2222533003: [Android] Pass known devices file path to host info to detect missing devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2222533003: [Android] Pass known devices file path to host info to detect missing devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium_android/api.py

diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py

index e343d2d12a1737a682913a01c0d87d462b48cbfd..d81169fb14abef7f39a140748565e5c154d0e6d3 100644

--- a/scripts/slave/recipe_modules/chromium_android/api.py

+++ b/scripts/slave/recipe_modules/chromium_android/api.py

@@ -374,6 +374,9 @@ class AndroidApi(recipe_api.RecipeApi):

results = None

try:

with self.handle_exit_codes():

+ if self.known_devices_file:

+ known_devices_arg = ['--known-devices-path', self.known_devices_file]

+ args.extend(['--args', self.m.json.input(known_devices_arg)])

args.extend(['run', '--output', self.m.json.output()])

results = self.m.step(

'Host Info',

« no previous file with comments | « no previous file | scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json » ('j') | no next file with comments »