Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html

Issue 2222163005: Updating media controls to give fullscreen button highest priority (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html
diff --git a/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html b/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html
new file mode 100644
index 0000000000000000000000000000000000000000..e6c310333e212fe904d3d6e071f68f48df370392
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/media/fullscreen-controls-visible-last.html
@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<title>Tests that the fullscreen button control is visible last.</title>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="media-file.js"></script>
+<script src="media-controls.js"></script>
+<script src="video-controls-fullscreen.js"></script>
mlamouri (slow - plz ping) 2016/08/10 15:34:24 Could you move hasFullscreenButton() to media-cont
kdsilva 2016/08/12 08:59:55 Done.
+<video controls></video>
+<script>
+async_test(function(t) {
+ var video = document.querySelector("video");
+ video.src = findMediaFile("video", "content/test");
+ video.setAttribute("width", "70");
+ video.addTextTrack("captions");
+ video.onloadeddata = t.step_func_done(function() {
+ assert_true(hasFullscreenButton(video));
+ assert_false(isClosedCaptionsButtonVisible(video));
+ });
+});
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698